diff options
| author | Sjors Provoost <sjors@sprovoost.nl> | 2019-06-28 22:44:38 -0400 |
|---|---|---|
| committer | Sjors Provoost <sjors@sprovoost.nl> | 2019-06-28 22:44:38 -0400 |
| commit | 806b0052c3b45415862f74f20ba5f389e5b673de (patch) | |
| tree | f8acbb20ec282a28fb0eba331a4e81d6a75872e4 /test/functional/rpc_fundrawtransaction.py | |
| parent | 7400135b7918df9c34206bead744c496e07b0e78 (diff) | |
| download | bitcoin-806b0052c3b45415862f74f20ba5f389e5b673de.tar.xz | |
[wallet] abort when attempting to fund a transaction above maxtxfee
FundTransaction calls GetMinimumFee which, when the fee rate is absurdly high, quietly reduced the fee to -maxtxfee. Becaue an absurdly high fee rate is usually the result of a fat finger, aborting seems safer behavior.
Diffstat (limited to 'test/functional/rpc_fundrawtransaction.py')
| -rwxr-xr-x | test/functional/rpc_fundrawtransaction.py | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/test/functional/rpc_fundrawtransaction.py b/test/functional/rpc_fundrawtransaction.py index d89fd6461f..cdf636e200 100755 --- a/test/functional/rpc_fundrawtransaction.py +++ b/test/functional/rpc_fundrawtransaction.py @@ -662,6 +662,7 @@ class RawTransactionsTest(BitcoinTestFramework): result = self.nodes[3].fundrawtransaction(rawtx) # uses min_relay_tx_fee (set by settxfee) result2 = self.nodes[3].fundrawtransaction(rawtx, {"feeRate": 2*min_relay_tx_fee}) result3 = self.nodes[3].fundrawtransaction(rawtx, {"feeRate": 10*min_relay_tx_fee}) + assert_raises_rpc_error(-4, "Fee exceeds maximum configured by -maxtxfee", self.nodes[3].fundrawtransaction, rawtx, {"feeRate": 1}) result_fee_rate = result['fee'] * 1000 / count_bytes(result['hex']) assert_fee_amount(result2['fee'], count_bytes(result2['hex']), 2 * result_fee_rate) assert_fee_amount(result3['fee'], count_bytes(result3['hex']), 10 * result_fee_rate) |