diff options
| author | Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> | 2022-03-10 15:41:30 +0100 |
|---|---|---|
| committer | Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> | 2022-03-10 15:57:03 +0100 |
| commit | 93feabcb30e34bfc458742e0e8b327b404599f29 (patch) | |
| tree | e3067acd8567e77731bf1d5cd8a0587ec40d3438 /test/functional/rpc_blockchain.py | |
| parent | 597ee30b5e2361a91e319fed65c0ece4ff30a5c9 (diff) | |
| parent | b7dbc83f23f67048cd6f66f5587381d73fad4894 (diff) | |
Merge bitcoin-core/gui#563: qt: Remove network detection based on address in BIP21
b7dbc83f23f67048cd6f66f5587381d73fad4894 qt: Remove network detection based on address in BIP21 (laanwj)
Pull request description:
This is removes some ugly and brittle code that switches the global network to testnet based on a provided address. I think in practice it's very unlikely for testnet BIP21 payment URIs to be used, and if so it's for testing so it's easy enough to manually copy it. Or to specify `-testnet` explicitly.
There is already no such case for `-regtest` or `-signet`.
After this change it will only accept addresses for the explicitly selected network. Others will result in a "wrong network" popup.
There is also a possibility for refactor after this as the initialization order of `PaymentServer::ipcParseCommandLine` isn't important anymore (well, it still has to be before `PaymentServer::ipcSendCommandLine`, maybe even merged with it), but I have not done so here.
ACKs for top commit:
jonatack:
ACK b7dbc83f23f67048cd6f66f5587381d73fad4894
achow101:
ACK b7dbc83f23f67048cd6f66f5587381d73fad4894
Tree-SHA512: ebc77c0e5c98f53fe254bcd0f94c9d1c06937b794346e95b14158860d5c607515e71d73b782d2726674dce86d6d4001085d473c6d1bc11c5e6c25ff3fb3cfa22
Diffstat (limited to 'test/functional/rpc_blockchain.py')
0 files changed, 0 insertions, 0 deletions