diff options
author | John Newbery <john@johnnewbery.com> | 2020-11-28 11:41:25 +0000 |
---|---|---|
committer | John Newbery <john@johnnewbery.com> | 2021-02-17 09:00:53 +0000 |
commit | 7e158a69104831611462cb555da931331b237c78 (patch) | |
tree | f971e3a91e458b076d793fa801e759a581cd955a /test/functional/p2p_filter.py | |
parent | 652311165c4ef298dab71d7162f9054abf439f77 (diff) | |
download | bitcoin-7e158a69104831611462cb555da931331b237c78.tar.xz |
[test] Move MY_VERSION to p2p.py
The messages.py module should contain code and helpers for
[de]serializing p2p messages. Specific usage of those messages should
be in p2p.py. Therefore move MY_VERSION to p2p.py.
Also rename to P2P_VERSION to distinguish it from
other versioning used in Bitcoin/Bitcoin Core.
Also always set the nVersion field in CBlockLocator to 0 and ignore the
field in deserialized messages. The field is not currently used for
anything in Bitcoin Core.
Diffstat (limited to 'test/functional/p2p_filter.py')
-rwxr-xr-x | test/functional/p2p_filter.py | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/test/functional/p2p_filter.py b/test/functional/p2p_filter.py index 458e5235b6..2324a3f588 100755 --- a/test/functional/p2p_filter.py +++ b/test/functional/p2p_filter.py @@ -19,7 +19,11 @@ from test_framework.messages import ( msg_mempool, msg_version, ) -from test_framework.p2p import P2PInterface, p2p_lock +from test_framework.p2p import ( + P2PInterface, + P2P_VERSION, + p2p_lock, +) from test_framework.script import MAX_SCRIPT_ELEMENT_SIZE from test_framework.test_framework import BitcoinTestFramework @@ -218,6 +222,7 @@ class FilterTest(BitcoinTestFramework): filter_peer_without_nrelay = self.nodes[0].add_p2p_connection(P2PBloomFilter(), send_version=False, wait_for_verack=False) # Send version with fRelay=False version_without_fRelay = msg_version() + version_without_fRelay.nVersion = P2P_VERSION version_without_fRelay.nRelay = 0 filter_peer_without_nrelay.send_message(version_without_fRelay) filter_peer_without_nrelay.wait_for_verack() |