diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2020-08-04 11:21:02 +0200 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2020-08-04 11:21:13 +0200 |
| commit | 3c93623be20d534bb653410db03d38152135e2e6 (patch) | |
| tree | 81fa93be329796fe18426001a6bc045c7950546b /test/functional/p2p_filter.py | |
| parent | bb2a9f9c8c555e6055d78a73f897bafc1c73c726 (diff) | |
| parent | faa9a74c9e99eb43ba0d27fa906767ee88011aeb (diff) | |
| download | bitcoin-3c93623be20d534bb653410db03d38152135e2e6.tar.xz | |
Merge #19489: test: Fail wait_until early if connection is lost
faa9a74c9e99eb43ba0d27fa906767ee88011aeb test: Fail wait_until early if connection is lost (MarcoFalke)
Pull request description:
Calling `minonode.wait_until` needs a connection to make progress (e.g. waiting for an inv), unless the mininode waits for the initial connection or for a disconnection. So for test development and failure debugging, fail early in all `wait_until`, unless opted out.
ACKs for top commit:
jnewbery:
Code review ACK faa9a74c9e99eb43ba0d27fa906767ee88011aeb.
Tree-SHA512: 4be850b96e23b87bc2ff42c028a5045d6f5cdbc9482ce6a6ba01cc5eb26710dab9e2ed547c363aac4bd5825151ee9996fb797261420b631bceeddbfa698d1dec
Diffstat (limited to 'test/functional/p2p_filter.py')
| -rwxr-xr-x | test/functional/p2p_filter.py | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/test/functional/p2p_filter.py b/test/functional/p2p_filter.py index 741da3be31..c8e2616b79 100755 --- a/test/functional/p2p_filter.py +++ b/test/functional/p2p_filter.py @@ -218,7 +218,11 @@ class FilterTest(BitcoinTestFramework): # Add peer but do not send version yet filter_peer_without_nrelay = self.nodes[0].add_p2p_connection(P2PBloomFilter(), send_version=False, wait_for_verack=False) # Send version with fRelay=False - filter_peer_without_nrelay.wait_until(lambda: filter_peer_without_nrelay.is_connected, timeout=10) + filter_peer_without_nrelay.wait_until( + lambda: filter_peer_without_nrelay.is_connected, + timeout=10, + check_connected=False, + ) version_without_fRelay = msg_version() version_without_fRelay.nRelay = 0 filter_peer_without_nrelay.send_message(version_without_fRelay) |