diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2021-10-06 13:04:46 +0200 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2021-10-06 13:05:12 +0200 |
| commit | 66d11b14357c474416181227e197406ca8fb5dee (patch) | |
| tree | 7a3af8f035b3b57bf53b85b155667c68787cf37f /test/functional/p2p_compactblocks_blocksonly.py | |
| parent | 113b863f0773999497f952daa6539a03a66a9de3 (diff) | |
| parent | 75a9305d455e234c6b63635d80b0f2aef902342e (diff) | |
| download | bitcoin-66d11b14357c474416181227e197406ca8fb5dee.tar.xz | |
Merge bitcoin/bitcoin#23200: Fix intermittent failure in wallet_send.py and rpc_fundrawtransaction.py
75a9305d455e234c6b63635d80b0f2aef902342e Fix intermittent test failures due to missing sync_all (Samuel Dobson)
eb02dbba3cd9f7294cd81e268cf85a1de7a71d02 Use self.generate not node.generate throughout tests (Samuel Dobson)
Pull request description:
After #17211 was merged, there have been a few intermittent test failures in `wallet_send.py`, `rpc_fundrawtransaction.py`, and `rpc_psbt.py`
I believe all these failures are due to these missing `sync_all()`s
ACKs for top commit:
achow101:
ACK 75a9305d455e234c6b63635d80b0f2aef902342e
lsilva01:
Tested ACK https://github.com/bitcoin/bitcoin/pull/23200/commits/75a9305d455e234c6b63635d80b0f2aef902342e on Ubuntu 20.04
Tree-SHA512: 91de5763664046e5a35802eb1a9a28f69a1a27d78d26c9fa0024bcfab4ccb4b7ad4feebea7de4b19e141db9c39270c623c57c47942a48dfe679fdc8cad70df43
Diffstat (limited to 'test/functional/p2p_compactblocks_blocksonly.py')
| -rwxr-xr-x | test/functional/p2p_compactblocks_blocksonly.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/functional/p2p_compactblocks_blocksonly.py b/test/functional/p2p_compactblocks_blocksonly.py index 4073ec03a6..5f01fa4dfe 100755 --- a/test/functional/p2p_compactblocks_blocksonly.py +++ b/test/functional/p2p_compactblocks_blocksonly.py @@ -33,7 +33,7 @@ class P2PCompactBlocksBlocksOnly(BitcoinTestFramework): self.sync_all() def build_block_on_tip(self): - blockhash = self.nodes[2].generate(1)[0] + blockhash = self.generate(self.nodes[2], 1)[0] block_hex = self.nodes[2].getblock(blockhash=blockhash, verbosity=0) block = from_hex(CBlock(), block_hex) block.rehash() |