diff options
| author | merge-script <falke.marco@gmail.com> | 2021-09-20 07:59:49 +0200 |
|---|---|---|
| committer | merge-script <falke.marco@gmail.com> | 2021-09-20 07:59:49 +0200 |
| commit | 226731ac1144886d693d3508b331f98727ab883c (patch) | |
| tree | 194efbc965858f5c43efb34ac867f7cbb6782331 /test/functional/mempool_reorg.py | |
| parent | 2560b6862b405c72daa03630c463673c3252020d (diff) | |
| parent | ebe49b5b7cda0f9e8dc4bb4795da0ca44a97aa1d (diff) | |
Merge bitcoin/bitcoin#23037: test: fix confusing off-by-one nValue in feature_coinstatsindex.py
ebe49b5b7cda0f9e8dc4bb4795da0ca44a97aa1d test: fix confusing off-by-one nValue in feature_coinstatsindex.py (Sebastian Falbesoner)
Pull request description:
Due to evil floating-point arithmetic, the creation of one of the transaction outputs in feature_coinstatsindex.py leads to it's nValue being off by one satoshi: the Python expression `int(21.99 * COIN)` doesn't yield 2199000000 as expected, but 2198999999.
This makes the test more confusing than necessary (w.r.t. the expected `gettxoutsetinfo` values), and could also cause problems if the value is ever changed. Fix by using a `Decimal` type for specifying the value in BTC, rather than using a bare floating-point.
ACKs for top commit:
MarcoFalke:
cr ACK ebe49b5b7cda0f9e8dc4bb4795da0ca44a97aa1d
Tree-SHA512: c74c51dbf99818f3d1c881873e0c053a649e4fed9b36767ff971dd3a48bff7122afea4e07cc9925236570368b45579f63e443701f2aaef838a0fafdbe986dfd4
Diffstat (limited to 'test/functional/mempool_reorg.py')
0 files changed, 0 insertions, 0 deletions