diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2020-11-19 16:30:48 +0100 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2020-11-19 16:30:54 +0100 |
| commit | 884bde510e2db59ee44604e2cccabb0bf1ef6ada (patch) | |
| tree | ca2ce055f254c3a73b2929d6e8905e4273ada3fe /test/functional/mempool_persist.py | |
| parent | c4d1e24f54805e2c8d28cd793d2f2f2a220fdf55 (diff) | |
| parent | 0bfce9dc46234b196a8b3679c21d6f8455962495 (diff) | |
Merge #20291: [net] Consolidate logic around calling CAddrMan::Connected()
0bfce9dc46234b196a8b3679c21d6f8455962495 [addrman] Fix Connected() comment (John Newbery)
eefe19471868ef0cdc9d32473d0b57015e7647ee [net] Consolidate logic around calling CAddrMan::Connected() (John Newbery)
Pull request description:
Currently, the logic around whether we called CAddrMan::Connected() for
a peer is spread between verack processing (where we discard inbound
peers) and FinalizeNode (where we discard misbehaving and
block-relay-only peers). Consolidate that logic to a single place.
Also remove the CNode.fCurrentlyConnected bool, which is now
redundant. We can rely on CNode.fSuccessfullyConnected, since the two
bools were only ever flipped to true in the same place.
ACKs for top commit:
mzumsande:
Code review ACK 0bfce9dc46234b196a8b3679c21d6f8455962495
amitiuttarwar:
code review ACK 0bfce9dc46. nice tidy, and bonus that we get to remove an unnecessary call to `cs_main`
Tree-SHA512: 1ab74dae3bc12a6846da57c853033e546bb4f91caa39f4c50bf0cf7eca59cb917bdb2ef795da55363e7e9f70949cb28bb3be004cb3afa4389f970d2fe097d932
Diffstat (limited to 'test/functional/mempool_persist.py')
0 files changed, 0 insertions, 0 deletions