diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2021-10-12 14:39:19 +0200 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2021-10-12 14:39:24 +0200 |
| commit | 810ce36d54e4a047f27a099e8295ddadfced75a9 (patch) | |
| tree | 668eff074be0a10a4290ed495826837172689dfc /test/functional/interface_rest.py | |
| parent | 8df7eee5e1c8ad6b224aa00bcfd7a04a974362c4 (diff) | |
| parent | fa8d49289479b8eda7ba7530515c414d1cd566a3 (diff) | |
Merge bitcoin/bitcoin#23213: rest: Return error when header count is not integral
fa8d49289479b8eda7ba7530515c414d1cd566a3 rest: Return error when header count is not integral (MarcoFalke)
Pull request description:
Seems odd to interpret a hash (or any other string) as integer when it contains more than the digits 0 to 9.
ACKs for top commit:
practicalswift:
cr ACK fa8d49289479b8eda7ba7530515c414d1cd566a3
promag:
Code review ACK fa8d49289479b8eda7ba7530515c414d1cd566a3.
shaavan:
Code Review ACK fa8d49289479b8eda7ba7530515c414d1cd566a3
Tree-SHA512: d6335b132ca2010fb8cae311dd936b2dea99a5bd0e6b2556a604f93698b8456df9190c5151345a03344243ede4aad0e2526cedc2aa8b5b1b8e8ce786cb3b6e50
Diffstat (limited to 'test/functional/interface_rest.py')
| -rwxr-xr-x | test/functional/interface_rest.py | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/test/functional/interface_rest.py b/test/functional/interface_rest.py index e0716fc54a..adc33bd9df 100755 --- a/test/functional/interface_rest.py +++ b/test/functional/interface_rest.py @@ -279,6 +279,13 @@ class RESTTest (BitcoinTestFramework): json_obj = self.test_rest_request(f"/headers/5/{bb_hash}") assert_equal(len(json_obj), 5) # now we should have 5 header objects + # Test number parsing + for num in ['5a', '-5', '0', '2001', '99999999999999999999999999999999999']: + assert_equal( + bytes(f'Header count out of range: {num}\r\n', 'ascii'), + self.test_rest_request(f"/headers/{num}/{bb_hash}", ret_type=RetType.BYTES, status=400), + ) + self.log.info("Test tx inclusion in the /mempool and /block URIs") # Make 3 tx and mine them on node 1 |