diff options
| author | fanquake <fanquake@gmail.com> | 2021-09-17 10:00:59 +0800 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2021-09-17 10:36:44 +0800 |
| commit | f7189c4ce950dc26bcfee9ec3825f312237baffe (patch) | |
| tree | 1ee2aa07f58dbf8e46befa15fb969ec6a8b2364c /test/functional/interface_bitcoin_cli.py | |
| parent | 6ef84e0503994c53f77093e7ea5951a7b0edea7a (diff) | |
| parent | 98cf19ca32785c991628324c313e01349c2986af (diff) | |
Merge bitcoin/bitcoin#22941: wallet: refactor: inline functions `{Read,Write}OrderPos`
98cf19ca32785c991628324c313e01349c2986af wallet: refactor: avoid duplicate lookup on `mapValue["timesmart"]` (Sebastian Falbesoner)
973d8ba93d0fa00bed4569287e32696300036ab8 wallet: refactor: inline function WriteOrderPos() (Sebastian Falbesoner)
65ed198295e58cf1bc339aa17349b83490872f70 wallet: refactor: inline function ReadOrderPos() (Sebastian Falbesoner)
Pull request description:
The functions `ReadOrderPos` and `WriteOrderPos` have been introduced in commit 9c7722b7c5ce49130bd978b932f73b629ce5cebe in 2012. Since accounts have been removed in #13825 (commit c9c32e6b844fc79467b7e24c6c916142a0d08484), they are only called at one place in `CWalletTx::{Serialize,Unserialize}` and thus can be directly inlined instead. Additionally, this PR aims to avoids duplicate lookups on the map `mapValue` (affects keys "n" and "timesmart").
ACKs for top commit:
laanwj:
Code review ACK 98cf19ca32785c991628324c313e01349c2986af
achow101:
Code Review ACK 98cf19ca32785c991628324c313e01349c2986af
Tree-SHA512: 8af63c174c79e589bd713f04e8e40caba9f93ec2978c805427cac50d48049808a8c23ff5eea9ef589c9bd79fc66087f43ff5ab28e3cda51dd03f37c0164e2e4c
Diffstat (limited to 'test/functional/interface_bitcoin_cli.py')
0 files changed, 0 insertions, 0 deletions