Merge #18576: test: use unittest for test_framework unit testing

de8905adf204c42bba810802f82b98f7b3dd26dc test: use unittest and test_runner for test framework unit testing (Gloria Zhao)

Pull request description:

  Proposal for unit testing on test_framework functions:
  1. Use the python `unittest` library. Don't use test_framework to test itself.
  2. Put the tests inside the same file as the functions they are testing.
  3. Call the tests from `test_runner.py`. To include more Test Framework tests, add the filename to the list `TEST_FRAMEWORK_MODULES`. Don't add new files or change the list of accepted script prefixes.

  Makes these changes for `bn2vch` (followup to [this comment](https://github.com/bitcoin/bitcoin/pull/18378#pullrequestreview-377271264)).

ACKs for top commit:
  jnewbery:
    Tested ACK de8905adf204c42bba810802f82b98f7b3dd26dc. Great stuff gzhao408 . Thanks for this!

Tree-SHA512: 91572d43e203a1864765b93a9472667994115ec38b271f2b2f9fcd0f0112b393fc24ba7d2371d5a34b0a6a4522f6b934fc5164363819aa7ed8d6c6c9a60cc101

1 files changed, 0 insertions, 44 deletions

diff --git a/test/functional/framework_test_script.py b/test/functional/framework_test_script.py
deleted file mode 100755
index 9d916c0022..0000000000
--- a/test/functional/framework_test_script.py
+++ /dev/null
@@ -1,44 +0,0 @@
-#!/usr/bin/env python3
-# Copyright (c) 2020 The Bitcoin Core developers
-# Distributed under the MIT software license, see the accompanying
-# file COPYING or http://www.opensource.org/licenses/mit-license.php.
-"""Tests for test_framework.script."""
-
-from test_framework.test_framework import BitcoinTestFramework
-from test_framework.script import bn2vch
-from test_framework.util import assert_equal
-
-def test_bn2vch():
-    assert_equal(bn2vch(0), bytes([]))
-    assert_equal(bn2vch(1), bytes([0x01]))
-    assert_equal(bn2vch(-1), bytes([0x81]))
-    assert_equal(bn2vch(0x7F), bytes([0x7F]))
-    assert_equal(bn2vch(-0x7F), bytes([0xFF]))
-    assert_equal(bn2vch(0x80), bytes([0x80, 0x00]))
-    assert_equal(bn2vch(-0x80), bytes([0x80, 0x80]))
-    assert_equal(bn2vch(0xFF), bytes([0xFF, 0x00]))
-    assert_equal(bn2vch(-0xFF), bytes([0xFF, 0x80]))
-    assert_equal(bn2vch(0x100), bytes([0x00, 0x01]))
-    assert_equal(bn2vch(-0x100), bytes([0x00, 0x81]))
-    assert_equal(bn2vch(0x7FFF), bytes([0xFF, 0x7F]))
-    assert_equal(bn2vch(-0x8000), bytes([0x00, 0x80, 0x80]))
-    assert_equal(bn2vch(-0x7FFFFF), bytes([0xFF, 0xFF, 0xFF]))
-    assert_equal(bn2vch(0x80000000), bytes([0x00, 0x00, 0x00, 0x80, 0x00]))
-    assert_equal(bn2vch(-0x80000000), bytes([0x00, 0x00, 0x00, 0x80, 0x80]))
-    assert_equal(bn2vch(0xFFFFFFFF), bytes([0xFF, 0xFF, 0xFF, 0xFF, 0x00]))
-
-    assert_equal(bn2vch(123456789), bytes([0x15, 0xCD, 0x5B, 0x07]))
-    assert_equal(bn2vch(-54321), bytes([0x31, 0xD4, 0x80]))
-
-class FrameworkTestScript(BitcoinTestFramework):
-    def setup_network(self):
-        pass
-
-    def set_test_params(self):
-        self.num_nodes = 0
-
-    def run_test(self):
-        test_bn2vch()
-
-if __name__ == '__main__':
-    FrameworkTestScript().main()