diff options
| author | Sebastian Falbesoner <sebastian.falbesoner@gmail.com> | 2021-11-12 18:29:43 +0100 |
|---|---|---|
| committer | Sebastian Falbesoner <sebastian.falbesoner@gmail.com> | 2021-11-12 18:29:43 +0100 |
| commit | a9872e1478af10ca335cca32abd248e87e103c02 (patch) | |
| tree | 4cc5005debf054d56e729c51fb46685c031544b4 /test/functional/feature_dersig.py | |
| parent | c9dd5c8d6e59e27af98e99d2844d6ead8eec3162 (diff) | |
| download | bitcoin-a9872e1478af10ca335cca32abd248e87e103c02.tar.xz | |
test: remove unnecessary block rehashing prior to solving
Solving a block involves continously rehashing it, i.e. any extra
calls to rehash it before are not necessary and can be dropped.
Diffstat (limited to 'test/functional/feature_dersig.py')
| -rwxr-xr-x | test/functional/feature_dersig.py | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/test/functional/feature_dersig.py b/test/functional/feature_dersig.py index 28aff1f2f9..eba3809d24 100755 --- a/test/functional/feature_dersig.py +++ b/test/functional/feature_dersig.py @@ -88,7 +88,6 @@ class BIP66Test(BitcoinTestFramework): block = create_block(int(tip, 16), create_coinbase(DERSIG_HEIGHT - 1), block_time) block.vtx.append(spendtx) block.hashMerkleRoot = block.calc_merkle_root() - block.rehash() block.solve() assert_equal(self.nodes[0].getblockcount(), DERSIG_HEIGHT - 2) @@ -103,7 +102,6 @@ class BIP66Test(BitcoinTestFramework): block_time += 1 block = create_block(tip, create_coinbase(DERSIG_HEIGHT), block_time) block.nVersion = 2 - block.rehash() block.solve() with self.nodes[0].assert_debug_log(expected_msgs=[f'{block.hash}, bad-version(0x00000002)']): @@ -133,7 +131,6 @@ class BIP66Test(BitcoinTestFramework): # Now we verify that a block with this transaction is also invalid. block.vtx.append(spendtx) block.hashMerkleRoot = block.calc_merkle_root() - block.rehash() block.solve() with self.nodes[0].assert_debug_log(expected_msgs=[f'CheckInputScripts on {block.vtx[-1].hash} failed with non-mandatory-script-verify-flag (Non-canonical DER signature)']): @@ -144,7 +141,6 @@ class BIP66Test(BitcoinTestFramework): self.log.info("Test that a block with a DERSIG-compliant transaction is accepted") block.vtx[1] = self.create_tx(self.coinbase_txids[1]) block.hashMerkleRoot = block.calc_merkle_root() - block.rehash() block.solve() self.test_dersig_info(is_active=True) # Not active as of current tip, but next block must obey rules |