diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2018-01-25 08:04:33 -0500 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2018-01-25 08:04:51 -0500 |
| commit | 598a9c4e4dcd03c6d80fba005de729a6a3aeba7e (patch) | |
| tree | 737acedfd3ef3f5e3a9c2ba96276e7b8c2cb4f14 /test/functional/feature_bip68_sequence.py | |
| parent | 6970b30c6f1d2be7947295fe18f2390649b17a4b (diff) | |
| parent | 1e2e09e2f6382ed239d974720126c642c3e3690c (diff) | |
Merge #12264: Fix versionbits warning test
1e2e09e2f6 Fix intermittent failure in p2p-versionbits-warning.py (John Newbery)
3bbd843708 Improve comments/logging in p2p-versionbits-warning.py (John Newbery)
ef2beb2c13 Fix flake8 warnings in p2p-versionbits-warning.py (John Newbery)
Pull request description:
fixes #12259 (and tidies up the test)
The problem was that the node was still in IBD at the point the last block was generated. UpdateTip() will not generate a warning if the node is still in IBD:
https://github.com/bitcoin/bitcoin/blob/cc5870a4057f0322509dde5877fb08258bf4ec50/src/validation.cpp#L2151
The 'proper' fix would be to remove the overenthusiastic latching in DoWarning:
https://github.com/bitcoin/bitcoin/blob/cc5870a4057f0322509dde5877fb08258bf4ec50/src/validation.cpp#L2135
so that more than one warning message can be output to `alertnotify`. Really we should suppress multiple messages of the same type, but allow messages to be output if they're for different warnings. That would mean the test wouldn't need to stop-start the node.
Tree-SHA512: 5c9aa5af7eba3c1350ea28482d57d3d79e3166c6224ceddb5d5a631090081d890d7403015e41f413c22990959a488cf1231f88bb825c54a609b24f89c450a1f6
Diffstat (limited to 'test/functional/feature_bip68_sequence.py')
0 files changed, 0 insertions, 0 deletions