diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2020-08-26 11:52:26 +0200 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2020-08-26 11:52:31 +0200 |
| commit | a12d9e5fd24a25bef476c10620317e43a5905754 (patch) | |
| tree | a9b66c9ad5a3e205df9721d8bddfa826cd19f175 /test/functional/feature_backwards_compatibility.py | |
| parent | e80e5b3e4f00f7031a26b83549c6c7198ac8adce (diff) | |
| parent | e2aa1a585a83971639572cd2c84565ec360deac9 (diff) | |
Merge #19687: refactor: make EncodeBase{32,64} consume Spans
e2aa1a585a83971639572cd2c84565ec360deac9 util: make EncodeBase64 consume Spans (Sebastian Falbesoner)
2bc207190e6f1818b04c9336f6e0d625b2a2a0ba util: make EncodeBase32 consume Spans (Sebastian Falbesoner)
Pull request description:
To simplify the interface of the Base32/Base64 encoding functions for raw data, this PR changes them from taking two arguments (pointer and length) to just one Span. Most calls to `EncodeBase64` pass data from `CDataStream` instances, which unfortunately internally work with `char*` pointers rather than `unsigned char*`, but thanks to the recently introduced `MakeUCharSpan` helper, converting them is quite easy.
ACKs for top commit:
MarcoFalke:
ACK e2aa1a585a83971639572cd2c84565ec360deac9 🐮
vasild:
ACK e2aa1a585
Tree-SHA512: 43bd3bd2ee8e3be2474db0a81dae9d9e88fac2464b96d1b042147106ed7433799dcba3000c69990511ecfc697b0c7306ce85f2ecb2293e2e44fd356c9694b150
Diffstat (limited to 'test/functional/feature_backwards_compatibility.py')
0 files changed, 0 insertions, 0 deletions