diff options
| author | Kiminuo <kiminuo@protonmail.com> | 2020-02-25 20:05:48 +0100 |
|---|---|---|
| committer | Kiminuo <kiminuo@protonmail.com> | 2020-06-02 08:03:02 +0200 |
| commit | bd7e530f010d43816bb05d6f1590d1cd36cdaa2c (patch) | |
| tree | b6d140aa5fe2cf2b851d2b6e140e26eaa44e996a /test/functional/data | |
| parent | 9bc7751cadbd038faf8ac1d62cda23fcf00d4cc2 (diff) | |
This PR adds initial support for type hints checking in python scripts.
Support for type hints was introduced in Python 3.5. Type hints make it easier to read and review code in my opinion. Also an IDE may discover a potential bug sooner. Yet, as PEP 484 says: "It should also be emphasized that Python will remain a dynamically typed language, and the authors have no desire to ever make type hints mandatory, even by convention."
Mypy is used in lint-python.sh to do the type checking. The package is standard so there is little chance that it will be abandoned. Mypy checks that type hints in source code are correct when they are not, it fails with an error.
Useful resources:
* https://docs.python.org/3.5/library/typing.html
* https://www.python.org/dev/peps/pep-0484/
Diffstat (limited to 'test/functional/data')
| -rw-r--r-- | test/functional/data/invalid_txs.py | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/test/functional/data/invalid_txs.py b/test/functional/data/invalid_txs.py index ae5721bec2..6e72db1d96 100644 --- a/test/functional/data/invalid_txs.py +++ b/test/functional/data/invalid_txs.py @@ -21,6 +21,7 @@ Invalid tx cases not covered here can be found by running: """ import abc +from typing import Optional from test_framework.messages import ( COutPoint, CTransaction, @@ -56,7 +57,7 @@ class BadTxTemplate: __metaclass__ = abc.ABCMeta # The expected error code given by bitcoind upon submission of the tx. - reject_reason = "" + reject_reason = "" # type: Optional[str] # Only specified if it differs from mempool acceptance error. block_reject_reason = "" |