diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2018-06-18 17:28:37 -0400 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2018-06-25 14:06:41 -0400 |
| commit | fa87da2f172ae2e6dc15e9ed156a3564a8ecfbdd (patch) | |
| tree | 2693cae5718e45e84182d85a4d041fc084d6bd8e /test/functional/README.md | |
| parent | fa1eac9cdb1a491d5947b6972b87833792a16fe3 (diff) | |
qa: Avoid start/stop of the network thread mid-test
Diffstat (limited to 'test/functional/README.md')
| -rw-r--r-- | test/functional/README.md | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/test/functional/README.md b/test/functional/README.md index fdd7c339c5..e6365222ff 100644 --- a/test/functional/README.md +++ b/test/functional/README.md @@ -76,7 +76,7 @@ over the network (`CBlock`, `CTransaction`, etc, along with the network-level wrappers for them, `msg_block`, `msg_tx`, etc). - P2P tests have two threads. One thread handles all network communication -with the bitcoind(s) being tested (using python's asyncore package); the other +with the bitcoind(s) being tested in a callback-based event loop; the other implements the test logic. - `P2PConnection` is the class used to connect to a bitcoind. `P2PInterface` @@ -84,10 +84,6 @@ contains the higher level logic for processing P2P payloads and connecting to the Bitcoin Core node application logic. For custom behaviour, subclass the P2PInterface object and override the callback methods. -- Call `network_thread_start()` after all `P2PInterface` objects are created to -start the networking thread. (Continue with the test logic in your existing -thread.) - - Can be used to write tests where specific P2P protocol behavior is tested. Examples tests are `p2p_unrequested_blocks.py`, `p2p_compactblocks.py`. |