diff options
author | fanquake <fanquake@gmail.com> | 2023-10-06 13:37:09 +0100 |
---|---|---|
committer | fanquake <fanquake@gmail.com> | 2023-10-06 13:51:44 +0100 |
commit | 1472df63f7a1a331440ca2bb37609a1393657da2 (patch) | |
tree | ee156a9d35b337234a3de9a39a8d17a89a583f6e /src | |
parent | 634b68f0dc6b837f774f646188281757c055c78a (diff) | |
parent | 0f83ab407ec5aa0591c54c03bcf408c7f2f0a192 (diff) |
Merge bitcoin/bitcoin#28253: test: display abrupt shutdown errors in console output
0f83ab407ec5aa0591c54c03bcf408c7f2f0a192 test: display abrupt shutdown errors in console output (furszy)
Pull request description:
Making it easier to debug errors in the CI environment,
particularly in scenarios where it's not immediately clear
what happened nor which node crashed (or shutdown abruptly).
A bit of context:
Currently, the test framework redirects each node's stderr output
stream to a different temporary file inside each node's data directory.
While this is sufficient for storing the error, it isn't very helpful for
understanding what happened just by reading the CI console output.
Most of the time, reading the stderr file in the CI environment is not
possible, because people don't have access to it.
Testing Note:
The displayed error difference can be observed by cherry-picking this
commit https://github.com/furszy/bitcoin-core/commit/9cc5393c0f24c774b4a59706fc7c7873a59573e7 on top of this branch and running any
functional test.
ACKs for top commit:
maflcko:
lgtm ACK 0f83ab407ec5aa0591c54c03bcf408c7f2f0a192
theStack:
ACK 0f83ab407ec5aa0591c54c03bcf408c7f2f0a192
Tree-SHA512: 83ce4d21d5316e8cb16a17d3fbe77b8649fced9e09410861d9674c233f6e9c34bcf573504e387e4f439c2841b2ee9855d0d35607fa13aa89eafe0080c45ee82d
Diffstat (limited to 'src')
0 files changed, 0 insertions, 0 deletions