diff options
| author | MacroFake <falke.marco@gmail.com> | 2022-05-04 09:50:14 +0200 |
|---|---|---|
| committer | MacroFake <falke.marco@gmail.com> | 2022-05-04 09:50:16 +0200 |
| commit | 880cec91fab1b487457f4285a4bbbc9a5b5aaecb (patch) | |
| tree | 0281dacfc6281987ffc7759c13d0460d08124ea5 /src | |
| parent | 12455acca2c3adf5c88ae9c1a02a7c192fe0f53b (diff) | |
| parent | c2b295881f852a9096c834334d6b84c988f579f5 (diff) | |
| download | bitcoin-880cec91fab1b487457f4285a4bbbc9a5b5aaecb.tar.xz | |
Merge bitcoin/bitcoin#25047: tidy: add readability-redundant-declaration
c2b295881f852a9096c834334d6b84c988f579f5 tidy: add readability-redundant-declaration (fanquake)
Pull request description:
ACKs for top commit:
vincenzopalazzo:
ACK https://github.com/bitcoin/bitcoin/pull/25047/commits/c2b295881f852a9096c834334d6b84c988f579f5
jonatack:
Review-only ACK c2b295881f852a9096c834334d6b84c988f579f5
Tree-SHA512: 992dd81f9d0c511efcd8d9d1a8c05fc1401b854272f28f7f31ca0922164ddd7d7c01bfcf5ca268472b5d68969137110f5c0844a52938d294750584e1a948a874
Diffstat (limited to 'src')
| -rw-r--r-- | src/.clang-tidy | 13 | ||||
| -rw-r--r-- | src/netaddress.cpp | 3 | ||||
| -rw-r--r-- | src/randomenv.cpp | 3 |
3 files changed, 12 insertions, 7 deletions
diff --git a/src/.clang-tidy b/src/.clang-tidy index fda95967f5..b1f543f610 100644 --- a/src/.clang-tidy +++ b/src/.clang-tidy @@ -1,2 +1,11 @@ -Checks: '-*,bugprone-argument-comment,modernize-use-nullptr' -WarningsAsErrors: 'bugprone-argument-comment,modernize-use-nullptr' +Checks: ' +-*, +bugprone-argument-comment, +modernize-use-nullptr, +readability-redundant-declaration, +' +WarningsAsErrors: ' +bugprone-argument-comment, +modernize-use-nullptr, +readability-redundant-declaration, +' diff --git a/src/netaddress.cpp b/src/netaddress.cpp index 7bf11a3e48..9717f7abce 100644 --- a/src/netaddress.cpp +++ b/src/netaddress.cpp @@ -20,9 +20,6 @@ #include <iterator> #include <tuple> -constexpr size_t CNetAddr::V1_SERIALIZATION_SIZE; -constexpr size_t CNetAddr::MAX_ADDRV2_SIZE; - CNetAddr::BIP155Network CNetAddr::GetBIP155Network() const { switch (m_net) { diff --git a/src/randomenv.cpp b/src/randomenv.cpp index 53ebeb31cd..c5dca346d6 100644 --- a/src/randomenv.cpp +++ b/src/randomenv.cpp @@ -57,8 +57,7 @@ #include <sys/auxv.h> #endif -//! Necessary on some platforms -extern char** environ; +extern char** environ; // NOLINT(readability-redundant-declaration): Necessary on some platforms namespace { |