diff options
author | fanquake <fanquake@gmail.com> | 2020-01-24 14:17:48 +0800 |
---|---|---|
committer | fanquake <fanquake@gmail.com> | 2020-01-24 15:35:57 +0800 |
commit | 28fbe68fdcac2a06f359b1e48555a3d23015c2b7 (patch) | |
tree | fc97c4193f625ce6c723091a8e36c0c4abfd89f3 /src | |
parent | fe3b58b95955644f5b8e1cd9080d414378f14755 (diff) | |
parent | 2525c096b002a89d4c561e1474800496ad8ebd7e (diff) | |
download | bitcoin-28fbe68fdcac2a06f359b1e48555a3d23015c2b7.tar.xz |
Merge #17740: build: remove configure checks for win libraries we don't link against
2525c096b002a89d4c561e1474800496ad8ebd7e build: remove configure checks for win libraries we don't link against (fanquake)
Pull request description:
While cross compiling, `HOST=x86_64-w64-mingw32`, none of these libs actually seem to be passed to the linker. i.e tailing a build with `make -j5 V=1 | rg -i 'mingwthrd|winspool|rpcrt4|crypt32'`.
I'm not 100% sure about `crypt32`, even though the majority of our Windows cryptography usage, i.e [`CryptAcquireContextW`](https://docs.microsoft.com/en-us/windows/win32/api/wincrypt/nf-wincrypt-cryptacquirecontextw) or [`CryptGenRandom`](https://docs.microsoft.com/en-us/windows/win32/api/wincrypt/nf-wincrypt-cryptgenrandom) is provided by `advapi32`.
Note that `rpcrt4` and `mingwthrd` are already missing from the MSVC build, so we can sync the remainder once it's clear what's actually needed. Hopefully sipsorcery can add some MSVC insight.
ACKs for top commit:
practicalswift:
ACK 2525c096b002a89d4c561e1474800496ad8ebd7e -- diff looks correct
sipsorcery:
ACK 2525c096b002a89d4c561e1474800496ad8ebd7e.
Tree-SHA512: c756618f85ce2ab1e14e5514dbdc490d94c1c6dfd7a3e3d3b16344ae302fb789585dd10b5c2d784f961f3115bec1d914615051b3184bea00dfbcc3c23884ab4a
Diffstat (limited to 'src')
0 files changed, 0 insertions, 0 deletions