diff options
| author | MacroFake <falke.marco@gmail.com> | 2022-05-23 18:59:21 +0200 |
|---|---|---|
| committer | MacroFake <falke.marco@gmail.com> | 2022-05-23 18:59:26 +0200 |
| commit | fbb90c44ac8a4121ce6ba7fcbf864084f35734ba (patch) | |
| tree | 1864f7d885eb4c689bbf879f8c20b975d9e98277 /src | |
| parent | 3368f84c4359750cebe48df7f3f551460f7e4372 (diff) | |
| parent | 908fb7e2ec37fe68675d38dbfee4df9f861bb2b5 (diff) | |
Merge bitcoin/bitcoin#25015: test: Use permissions from git in lint-files.py
908fb7e2ec37fe68675d38dbfee4df9f861bb2b5 test: Use permissions from git in `lint-files.py` (laanwj)
48d2e80a7479a44b0ab09e87542c8cb7a8f72223 test: Don't use shell=True in `lint-files.py` (laanwj)
Pull request description:
Improvements to the `lint-files.py` script:
- Avoid use of `shell=True`.
- Check the permissions in git's metadata instead of in the filesystem. This stops the umask or filesystem from interfering. It's also more efficient as it only needs a single call to `git ls-files`.
(what triggered this change was `File "..." contains a shebang line, but has the file permission 775 instead of the expected executable permission 755.` errors running the script locally).
ACKs for top commit:
vincenzopalazzo:
re-tACK https://github.com/bitcoin/bitcoin/commit/908fb7e2ec37fe68675d38dbfee4df9f861bb2b5
Tree-SHA512: 2eaf868c55a9c3508b12658a5b3ac429963fd0551e645332d0ac54be56fefccee95115e4667386df24b46b545593cb0d0bf8c6cecab73f9cb19d37ddf704c614
Diffstat (limited to 'src')
0 files changed, 0 insertions, 0 deletions