diff options
author | John Newbery <john@johnnewbery.com> | 2021-07-20 13:59:12 +0100 |
---|---|---|
committer | John Newbery <john@johnnewbery.com> | 2021-07-20 16:17:51 +0100 |
commit | f036dfbb692c4d44d0f59194d089ed0aa1096347 (patch) | |
tree | cc43da695b6d50e075d981064c29290a9735faa5 /src | |
parent | 201c5e4aec5210b258644ff96379cda0ca7273ab (diff) | |
download | bitcoin-f036dfbb692c4d44d0f59194d089ed0aa1096347.tar.xz |
[addrman] Remove unused test_before_evict argument from Good()
This has never been used in the public interface method since it was
introduced in #9037.
Diffstat (limited to 'src')
-rw-r--r-- | src/addrman.h | 4 | ||||
-rw-r--r-- | src/test/addrman_tests.cpp | 2 | ||||
-rw-r--r-- | src/test/fuzz/addrman.cpp | 2 |
3 files changed, 4 insertions, 4 deletions
diff --git a/src/addrman.h b/src/addrman.h index 6f081b8dc1..1fc64ac07f 100644 --- a/src/addrman.h +++ b/src/addrman.h @@ -536,12 +536,12 @@ public: } //! Mark an entry as accessible. - void Good(const CService &addr, bool test_before_evict = true, int64_t nTime = GetAdjustedTime()) + void Good(const CService &addr, int64_t nTime = GetAdjustedTime()) EXCLUSIVE_LOCKS_REQUIRED(!cs) { LOCK(cs); Check(); - Good_(addr, test_before_evict, nTime); + Good_(addr, /* test_before_evict */ true, nTime); Check(); } diff --git a/src/test/addrman_tests.cpp b/src/test/addrman_tests.cpp index 1103292c1a..5e5c5eba69 100644 --- a/src/test/addrman_tests.cpp +++ b/src/test/addrman_tests.cpp @@ -76,7 +76,7 @@ public: { int64_t nLastSuccess = 1; // Set last good connection in the deep past. - Good(addr, true, nLastSuccess); + Good(addr, nLastSuccess); bool count_failure = false; int64_t nLastTry = GetAdjustedTime()-61; diff --git a/src/test/fuzz/addrman.cpp b/src/test/fuzz/addrman.cpp index db0b461873..8513f1e6df 100644 --- a/src/test/fuzz/addrman.cpp +++ b/src/test/fuzz/addrman.cpp @@ -80,7 +80,7 @@ FUZZ_TARGET_INIT(addrman, initialize_addrman) [&] { const std::optional<CService> opt_service = ConsumeDeserializable<CService>(fuzzed_data_provider); if (opt_service) { - addr_man.Good(*opt_service, fuzzed_data_provider.ConsumeBool(), ConsumeTime(fuzzed_data_provider)); + addr_man.Good(*opt_service, ConsumeTime(fuzzed_data_provider)); } }, [&] { |