diff options
| author | MacroFake <falke.marco@gmail.com> | 2022-08-31 15:59:52 +0200 |
|---|---|---|
| committer | MacroFake <falke.marco@gmail.com> | 2022-08-31 15:59:56 +0200 |
| commit | b9361231105bdd1f64a0396562d756910e37370d (patch) | |
| tree | b01357dd26f4a3b16d2afaefe14b5013c8b63a96 /src | |
| parent | 01e1627e25bc5477c40f51da03c3c31b609a85c9 (diff) | |
| parent | 6b24dfe24d2ed50ea0b06ce1919db3dc0e871a03 (diff) | |
| download | bitcoin-b9361231105bdd1f64a0396562d756910e37370d.tar.xz | |
Merge bitcoin/bitcoin#25963: CBlockLocator: performance-move-const-arg Clang tidy fixup
6b24dfe24d2ed50ea0b06ce1919db3dc0e871a03 CBlockLocator: performance-move-const-arg Clang tidy fixups (Jon Atack)
Pull request description:
Fix Clang-tidy CI errors on master. See https://cirrus-ci.com/task/4806752200818688?logs=ci#L4696 for an example.
ACKs for top commit:
MarcoFalke:
review ACK 6b24dfe24d2ed50ea0b06ce1919db3dc0e871a03
vasild:
ACK 6b24dfe24d2ed50ea0b06ce1919db3dc0e871a03
Tree-SHA512: 7a67acf7b42da07b63fbb392236e9a7be8cf35c36e37ca980c4467fe8295c2eda8aef10f41a1e3036cd9ebece47fa957fc3256033f853bd6a97ce2ca42799a0a
Diffstat (limited to 'src')
| -rw-r--r-- | src/chain.cpp | 2 | ||||
| -rw-r--r-- | src/primitives/block.h | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/chain.cpp b/src/chain.cpp index 19c35b5012..66a0830394 100644 --- a/src/chain.cpp +++ b/src/chain.cpp @@ -49,7 +49,7 @@ std::vector<uint256> LocatorEntries(const CBlockIndex* index) CBlockLocator GetLocator(const CBlockIndex* index) { - return CBlockLocator{std::move(LocatorEntries(index))}; + return CBlockLocator{LocatorEntries(index)}; } CBlockLocator CChain::GetLocator() const diff --git a/src/primitives/block.h b/src/primitives/block.h index 76aba6c899..2e26e6c426 100644 --- a/src/primitives/block.h +++ b/src/primitives/block.h @@ -123,7 +123,7 @@ struct CBlockLocator CBlockLocator() {} - explicit CBlockLocator(const std::vector<uint256>& vHaveIn) : vHave(vHaveIn) {} + explicit CBlockLocator(std::vector<uint256>&& have) : vHave(std::move(have)) {} SERIALIZE_METHODS(CBlockLocator, obj) { |