diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2020-10-21 14:43:06 +0200 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2020-10-21 14:43:12 +0200 |
| commit | 47fc883106fb939db0212751c2edb3d5f7430689 (patch) | |
| tree | cc3d9e6b519de0aa37bf1d70cff34b3e14d5bcd3 /src | |
| parent | 0f86e7f1285c6de697d144a0e68bbd67f4900e19 (diff) | |
| parent | 3c7d9ab8c8ec5284cdad1a53ee310b79b931f12f (diff) | |
Merge #19967: test: Replace (dis)?connect_nodes globals with TestFramework methods
3c7d9ab8c8ec5284cdad1a53ee310b79b931f12f test: Move (dis)?connect_nodes globals into TestFramework as helpers (Elliott Jin)
4b16c614616c1ff09e5b1dcd58516bcb9a88e5e8 scripted-diff: test: Replace uses of (dis)?connect_nodes global (Prayank)
be386840d4a394a1b6221fb7d0fa2b0bc4b1d413 test: Replace use of (dis)?connect_nodes globals (Elliott Jin)
Pull request description:
`util.py` defines global helper functions `connect_nodes` and `disconnect_nodes`; however, these functions are confusing because they take a node and an index (instead of two indexes).
The `TestFramework` object has enough context to convert from `i` to `self.nodes[i]`, so we can replace all instances of `connect_nodes(self.nodes[a], b)` with `self.connect_nodes(a, b)`. Similarly, we can replace instances of `disconnect_nodes`.
The approach taken in this PR builds on #19945 but uses a scripted-diff for the majority of the changes.
Fixes: #19821
ACKs for top commit:
MarcoFalke:
ACK 3c7d9ab8c8ec5284cdad1a53ee310b79b931f12f
guggero:
ACK 3c7d9ab8
Tree-SHA512: e027092748602904abcd986d7299624c8754c3236314b6d8e392e306741c212f266c2207e385adfb194f67ae6559a585ee7b15d639b1d65c4651dbf503e5931a
Diffstat (limited to 'src')
0 files changed, 0 insertions, 0 deletions