diff options
author | Gavin Andresen <gavinandresen@gmail.com> | 2012-04-29 20:56:55 -0400 |
---|---|---|
committer | Luke Dashjr <luke-jr+git@utopios.org> | 2012-05-04 18:52:16 +0000 |
commit | ad5a4c7c471912aa0bef52c33a1abfb01fe6d89d (patch) | |
tree | 61716d347a7ee0458ce4f964f29d5643c3de264f /src | |
parent | cae1a682678e94015ff89be2c6fa6484c8ef6fbe (diff) | |
download | bitcoin-ad5a4c7c471912aa0bef52c33a1abfb01fe6d89d.tar.xz |
Check earlier for blocks with duplicate transactions. Fixes #1167
Diffstat (limited to 'src')
-rw-r--r-- | src/main.cpp | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/src/main.cpp b/src/main.cpp index e6f94210b9..e8cbc01c7f 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -1472,6 +1472,16 @@ bool CBlock::CheckBlock() const if (!tx.CheckTransaction()) return error("CheckBlock() : CheckTransaction failed"); + // Check for duplicate txids. This is caught by ConnectInputs(), + // but catching it earlier avoids a potential DoS attack: + set<uint256> uniqueTx; + BOOST_FOREACH(const CTransaction& tx, vtx) + { + uniqueTx.insert(tx.GetHash()); + } + if (uniqueTx.size() != vtx.size()) + return error("CheckBlock() : duplicate transaction"); + // Check that it's not full of nonstandard transactions if (GetSigOpCount() > MAX_BLOCK_SIGOPS) return error("CheckBlock() : out-of-bounds SigOpCount"); |