diff options
author | John Newbery <john@johnnewbery.com> | 2017-02-09 16:27:28 -0500 |
---|---|---|
committer | John Newbery <john@johnnewbery.com> | 2017-03-07 16:45:09 -0500 |
commit | 960bc7f778d8dd618e65f1e37ec734e2d4734051 (patch) | |
tree | 016914cfdb765f2fbaf5a2dabed94235c897854b /src | |
parent | c1190963b388590dc0a346bf625c7e84f69cee8d (diff) | |
download | bitcoin-960bc7f778d8dd618e65f1e37ec734e2d4734051.tar.xz |
Return correct error codes in removeprunedfunds().
The removeprunedfunds() RPC was returning misleading or incorrect error
codes (for example RPC_INTERNAL_ERROR when the transaction was
not found in the wallet). This commit fixes those error codes:
- RPC_INTERNAL_ERROR should not be returned for application-level
errors, only for genuine internal errors such as corrupted data.
This error code has been replaced with RPC_WALLET_ERROR.
This commit also updates the test cases to explicitly test the error code.
Diffstat (limited to 'src')
-rw-r--r-- | src/wallet/rpcdump.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/wallet/rpcdump.cpp b/src/wallet/rpcdump.cpp index e02c6513e4..ad5ecf4976 100644 --- a/src/wallet/rpcdump.cpp +++ b/src/wallet/rpcdump.cpp @@ -350,11 +350,11 @@ UniValue removeprunedfunds(const JSONRPCRequest& request) vector<uint256> vHashOut; if (pwallet->ZapSelectTx(vHash, vHashOut) != DB_LOAD_OK) { - throw JSONRPCError(RPC_INTERNAL_ERROR, "Could not properly delete the transaction."); + throw JSONRPCError(RPC_WALLET_ERROR, "Could not properly delete the transaction."); } if(vHashOut.empty()) { - throw JSONRPCError(RPC_INTERNAL_ERROR, "Transaction does not exist in wallet."); + throw JSONRPCError(RPC_INVALID_PARAMETER, "Transaction does not exist in wallet."); } return NullUniValue; |