aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorHennadii Stepanov <32963518+hebasto@users.noreply.github.com>2020-09-01 12:12:47 +0300
committerHennadii Stepanov <32963518+hebasto@users.noreply.github.com>2020-09-01 12:34:11 +0300
commit939807768acd508932f2efabee660d56324a73df (patch)
treea5613b17a715fbbd089922b342d379fcbdca5a66 /src
parentbab4cce1b0eedc1a51692aaf83ba54dd0a9d17e6 (diff)
downloadbitcoin-939807768acd508932f2efabee660d56324a73df.tar.xz
refactor: CTxMemPool::UpdateParent() requires CTxMemPool::cs lock
No change in behavior, the lock is already held at call sites.
Diffstat (limited to 'src')
-rw-r--r--src/txmempool.cpp1
-rw-r--r--src/txmempool.h2
2 files changed, 2 insertions, 1 deletions
diff --git a/src/txmempool.cpp b/src/txmempool.cpp
index de1a3ec68f..ef2ec661e8 100644
--- a/src/txmempool.cpp
+++ b/src/txmempool.cpp
@@ -978,6 +978,7 @@ void CTxMemPool::UpdateChild(txiter entry, txiter child, bool add)
void CTxMemPool::UpdateParent(txiter entry, txiter parent, bool add)
{
+ AssertLockHeld(cs);
setEntries s;
if (add && mapLinks[entry].parents.insert(parent).second) {
cachedInnerUsage += memusage::IncrementalDynamicUsage(s);
diff --git a/src/txmempool.h b/src/txmempool.h
index 4743e1b63a..fbff1afcca 100644
--- a/src/txmempool.h
+++ b/src/txmempool.h
@@ -568,7 +568,7 @@ private:
typedef std::map<txiter, TxLinks, CompareIteratorByHash> txlinksMap;
txlinksMap mapLinks;
- void UpdateParent(txiter entry, txiter parent, bool add);
+ void UpdateParent(txiter entry, txiter parent, bool add) EXCLUSIVE_LOCKS_REQUIRED(cs);
void UpdateChild(txiter entry, txiter child, bool add);
std::vector<indexed_transaction_set::const_iterator> GetSortedDepthAndScore() const EXCLUSIVE_LOCKS_REQUIRED(cs);