aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorSishir Giri <sishirg27@gmail.com>2020-10-18 18:01:42 -0700
committerJohn Newbery <john@johnnewbery.com>2020-11-02 08:38:38 +0000
commit2ead31fb1b17c9b183a4b81f0ae4f48e5cf67d64 (patch)
tree24dd306bde6f4d459d67739446e7027d33678189 /src
parent867dbeba5f91be15ca0d4a7303a71957ff9a37ad (diff)
downloadbitcoin-2ead31fb1b17c9b183a4b81f0ae4f48e5cf67d64.tar.xz
[wallet] Return object from upgradewallet RPC
Diffstat (limited to 'src')
-rw-r--r--src/wallet/rpcwallet.cpp13
1 files changed, 11 insertions, 2 deletions
diff --git a/src/wallet/rpcwallet.cpp b/src/wallet/rpcwallet.cpp
index 086ffa1272..8aaa03e0c9 100644
--- a/src/wallet/rpcwallet.cpp
+++ b/src/wallet/rpcwallet.cpp
@@ -4443,7 +4443,12 @@ static RPCHelpMan upgradewallet()
{
{"version", RPCArg::Type::NUM, /* default */ strprintf("%d", FEATURE_LATEST), "The version number to upgrade to. Default is the latest wallet version"}
},
- RPCResults{},
+ RPCResult{
+ RPCResult::Type::OBJ, "", "",
+ {
+ {RPCResult::Type::STR, "error", /* optional */ true, "Error message (if there is one)"}
+ },
+ },
RPCExamples{
HelpExampleCli("upgradewallet", "169900")
+ HelpExampleRpc("upgradewallet", "169900")
@@ -4468,7 +4473,11 @@ static RPCHelpMan upgradewallet()
if (!pwallet->UpgradeWallet(version, error, warnings)) {
throw JSONRPCError(RPC_WALLET_ERROR, error.original);
}
- return error.original;
+ UniValue obj(UniValue::VOBJ);
+ if (!error.empty()) {
+ obj.pushKV("error", error.original);
+ }
+ return obj;
},
};
}