diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2020-11-03 09:48:12 +0100 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2020-11-03 09:48:15 +0100 |
| commit | 218fe60d91a9190aa0ee561479044df368214766 (patch) | |
| tree | 86652870c0f08876fdbfcf872f3a0d180c2df7d4 /src | |
| parent | 5174b534da57066dca2e82a617c62919b6d638fd (diff) | |
| parent | 28f8cb13d4d5a3d6aefa6e192e55f9aa87579e52 (diff) | |
| download | bitcoin-218fe60d91a9190aa0ee561479044df368214766.tar.xz | |
Merge #20290: fuzz: Fix DecodeHexTx fuzzing harness issue
28f8cb13d4d5a3d6aefa6e192e55f9aa87579e52 fuzz: Fix DecodeHexTx fuzzing harness issue (practicalswift)
Pull request description:
Fix `DecodeHexTx` fuzzing harness issue.
Before this patch:
```
$ src/test/fuzz/decode_tx
decode_tx: test/fuzz/decode_tx.cpp:29:
void test_one_input(const std::vector<uint8_t> &):
Assertion `result_try_witness_and_maybe_no_witness' failed.
…
```
After this patch:
```
$ src/test/fuzz/decode_tx
…
```
ACKs for top commit:
MarcoFalke:
review ACK 28f8cb13d4d5a3d6aefa6e192e55f9aa87579e52
Tree-SHA512: 2ed11b2f00a4c6fa3e8eea76a2a37d89a4b8d52815264676fe3de0a26ad7906cfafda9b843ceede2fd428815472e01fd1f87afb851282a8c7839bd4c87dc382b
Diffstat (limited to 'src')
| -rw-r--r-- | src/test/fuzz/decode_tx.cpp | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/test/fuzz/decode_tx.cpp b/src/test/fuzz/decode_tx.cpp index 0d89d4228a..a29686cbdd 100644 --- a/src/test/fuzz/decode_tx.cpp +++ b/src/test/fuzz/decode_tx.cpp @@ -24,8 +24,7 @@ void test_one_input(const std::vector<uint8_t>& buffer) if (result_try_witness_and_maybe_no_witness) { assert(result_try_no_witness || result_try_witness); } - // if (result_try_no_witness) { // Uncomment when https://github.com/bitcoin/bitcoin/pull/17775 is merged - if (result_try_witness) { // Remove stop-gap when https://github.com/bitcoin/bitcoin/pull/17775 is merged + if (result_try_no_witness) { assert(result_try_witness_and_maybe_no_witness); } } |