diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2019-03-29 13:21:21 -0400 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2019-03-29 13:21:24 -0400 |
| commit | 0baf4b1f96635cdf5f26b36753321fe3ea40d4a8 (patch) | |
| tree | 5dd0dabe4151638acc66d6e6bbf288f6a00c4c15 /src | |
| parent | dc5c2e4407463b6aadad2bee7495bb7576385cf8 (diff) | |
| parent | 2a1408c3ec036d9f89c4241689cd16f26093b209 (diff) | |
| download | bitcoin-0baf4b1f96635cdf5f26b36753321fe3ea40d4a8.tar.xz | |
Merge #15683: Comment for seemingly duplicate LIBBITCOIN_SERVER
2a1408c3ec Comment for seemingly duplicate LIBBITCOIN_SERVER (Peter Bushnell)
Pull request description:
Added a comment to explain the addition of LIBBITCOIN_SERVER twice in bitcoind_LDADD which seems incorrect at a glance until the behaviour of Linux linkers is understood.
ACKs for commit 2a1408:
practicalswift:
ACK 2a1408c3ec036d9f89c4241689cd16f26093b209
MarcoFalke:
ACK 2a1408c
fanquake:
utACK 2a1408c
ryanofsky:
utACK 2a1408c3ec036d9f89c4241689cd16f26093b209
Tree-SHA512: dd2a7f61d53ce8882a56c831c32e1f48e9eab741ef21361f195c38bb455abdc4bc524d3b44b6f69c7498898cd871a23c39d215de28db3b20ef5fd2135d5e136a
Diffstat (limited to 'src')
| -rw-r--r-- | src/Makefile.am | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/Makefile.am b/src/Makefile.am index bef2c10636..8f0110b43e 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -497,6 +497,8 @@ if TARGET_WINDOWS bitcoind_SOURCES += bitcoind-res.rc endif +# Libraries below may be listed more than once to resolve circular dependencies (see +# https://eli.thegreenplace.net/2013/07/09/library-order-in-static-linking#circular-dependency) bitcoind_LDADD = \ $(LIBBITCOIN_SERVER) \ $(LIBBITCOIN_WALLET) \ |