diff options
| author | Wladimir J. van der Laan <laanwj@gmail.com> | 2017-11-18 12:05:27 +0100 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@gmail.com> | 2017-11-18 12:05:31 +0100 |
| commit | 938863965f14ce7ab0780dd9197c6e13f2093d87 (patch) | |
| tree | 3e9418d481ad693fea5586599e755ccaecacc30b /src | |
| parent | 142913296f006650127b7a2ef03954e46bfd585c (diff) | |
| parent | dcfef277b4920552f438c110390a5de93892a8de (diff) | |
| download | bitcoin-938863965f14ce7ab0780dd9197c6e13f2093d87.tar.xz | |
Merge #11710: cli: Reject arguments to -getinfo
dcfef27 cli: Reject arguments to -getinfo (Wladimir J. van der Laan)
Pull request description:
Currently it's possible to accidentally type e.g.
bitcoin-cli -getinfo getbalance
and get an answer which can be confusing; the trailing arguments are just ignored.
To avoid this, throw an error if the user provides arguments to
`-getinfo`.
Tree-SHA512: 3603e8fa852b884d1dd3b7462db40b092fe8b3390fd4384b4ee330315d797aff711e9f62990012fd4b5a55c8678734ba8497a5488a09ee6b65cf8a99017d6eb4
Diffstat (limited to 'src')
| -rw-r--r-- | src/bitcoin-cli.cpp | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/bitcoin-cli.cpp b/src/bitcoin-cli.cpp index 5e3b76a295..136981b709 100644 --- a/src/bitcoin-cli.cpp +++ b/src/bitcoin-cli.cpp @@ -213,6 +213,9 @@ public: /** Create a simulated `getinfo` request. */ UniValue PrepareRequest(const std::string& method, const std::vector<std::string>& args) override { + if (!args.empty()) { + throw std::runtime_error("-getinfo takes no arguments"); + } UniValue result(UniValue::VARR); result.push_back(JSONRPCRequestObj("getnetworkinfo", NullUniValue, ID_NETWORKINFO)); result.push_back(JSONRPCRequestObj("getblockchaininfo", NullUniValue, ID_BLOCKCHAININFO)); |