diff options
| author | Wladimir J. van der Laan <laanwj@gmail.com> | 2017-10-18 15:22:30 +0200 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@gmail.com> | 2017-10-18 15:22:54 +0200 |
| commit | ffa5159cefb8a03ca75d3637adefecf12162dfd8 (patch) | |
| tree | e164ccffb7facfff51fcc47dbd233e667234daec /src | |
| parent | 26fee4f6bd9aec62c6caa60683ad66574cf16aa6 (diff) | |
| parent | 207408b0889caf3f5986bde4b122dbece1ed0dac (diff) | |
| download | bitcoin-ffa5159cefb8a03ca75d3637adefecf12162dfd8.tar.xz | |
Merge #11508: Fix crash via division by zero assertion
207408b Fix crash via division by zero assertion (Jonas Schnelli)
Pull request description:
Replaces the newly added `assert` for a devision by zero protection by a control structure. Floating point division by zero is defined by the floating point standard and results in +inf or -inf.
Introduced in #11133
Reported by @mzhou, fixes #11501
Tree-SHA512: ac9b4efa3ba52a2aa246fb11170128c4aaf829fd491b649524c85069c6ed33ae612e761809aea9d9a44bdea29a417b3f3a558226495094b5070a42a56b2ac77e
Diffstat (limited to 'src')
| -rw-r--r-- | src/qt/coincontroldialog.cpp | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/qt/coincontroldialog.cpp b/src/qt/coincontroldialog.cpp index 6952eb5064..207e441b6b 100644 --- a/src/qt/coincontroldialog.cpp +++ b/src/qt/coincontroldialog.cpp @@ -582,8 +582,7 @@ void CoinControlDialog::updateLabels(WalletModel *model, QDialog* dialog) QString toolTipDust = tr("This label turns red if any recipient receives an amount smaller than the current dust threshold."); // how many satoshis the estimated fee can vary per byte we guess wrong - assert(nBytes != 0); - double dFeeVary = (double)nPayFee / nBytes; + double dFeeVary = (nBytes != 0) ? (double)nPayFee / nBytes : 0; QString toolTip4 = tr("Can vary +/- %1 satoshi(s) per input.").arg(dFeeVary); |