diff options
author | Wladimir J. van der Laan <laanwj@gmail.com> | 2018-03-06 21:55:23 +0100 |
---|---|---|
committer | Wladimir J. van der Laan <laanwj@gmail.com> | 2018-03-06 21:55:37 +0100 |
commit | b7c8812ad0c2b10a760c5b900c18275620b8c675 (patch) | |
tree | 44f0f17f8a1e277c7e69bcd90586c7b4e85d84eb /src | |
parent | 85424d79eded606a61cd6a2a3173b8bd04e1201c (diff) | |
parent | 22b4aae0284511e9a6a957197dae237a1799aa20 (diff) | |
download | bitcoin-b7c8812ad0c2b10a760c5b900c18275620b8c675.tar.xz |
Merge #12564: [arith_uint256] Avoid unnecessary this-copy using prefix operator
22b4aae02 [arith_uint256] Avoid unnecessary this-copy using prefix operator (Karl-Johan Alm)
Pull request description:
I noticed while profiling a related project that `operator-()` actually calls the `base_uint` constructor, which is because the postfix operator version of `operator++` (used in `operator-()`) creates a copy of `this` and returns it.
Tree-SHA512: d9a2665caa3d93f064cdeaf1c6fada101b9943bb53d93ccac6d9a0edac20279d2e921349e30239039c71e0a9629e45c29ec9f10d8d7499e936cdba6cb7c3c3eb
Diffstat (limited to 'src')
-rw-r--r-- | src/arith_uint256.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/arith_uint256.h b/src/arith_uint256.h index dc2627592e..3f4cc8c2bf 100644 --- a/src/arith_uint256.h +++ b/src/arith_uint256.h @@ -85,7 +85,7 @@ public: base_uint ret; for (int i = 0; i < WIDTH; i++) ret.pn[i] = ~pn[i]; - ret++; + ++ret; return ret; } |