diff options
| author | Wladimir J. van der Laan <laanwj@gmail.com> | 2018-06-18 15:19:23 +0200 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@gmail.com> | 2018-06-18 15:31:16 +0200 |
| commit | 2d071f5a7055f85d1c7d92de43646663a03a8fce (patch) | |
| tree | 46c481e07a418f838be4e3c2bf08896d7334aaae /src | |
| parent | d67eff8002d7e14169a01b5dabcc998e98642639 (diff) | |
| parent | 55771b7c6a8d4a204c63e70db73a0071c41a0dc4 (diff) | |
| download | bitcoin-2d071f5a7055f85d1c7d92de43646663a03a8fce.tar.xz | |
Merge #13443: Removed unused == operator from CMutableTransaction.
55771b7c6a8d4a204c63e70db73a0071c41a0dc4 Removed unused == operator from CMutableTransaction. (lucash.dev@gmail.com)
Pull request description:
This removes the unused == operator from `CMutableTransaction`.
The motivation is that unused code has a cost but offers no benefit (in general), while also adding the risk of introducing silent bugs. On top of that this particular code is quite inefficient, unnecessarily calculating the hash (it could, say, compare serializations). So if anyone ever needs to use a == comparison on `CMutableTransaction`, they'd be better of having to reimplement it (and add tests) than relying on code that's not being maintained.
Note: after this, trying to use the == operator on CMutableTransactions results in a compilation error:
```
./primitives/transaction.h:405:15: error: invalid operands to binary expression ('CMutableTransaction' and
'CMutableTransaction')
```
Tree-SHA512: a565af563e09d99347b6fe419f6d48c750b1377295af293a3e0c3c0d815e58aede8d7058987a68d66cfa7ed023e5d3285b12afabd17d0ff9cf11322ba3ce20fe
Diffstat (limited to 'src')
| -rw-r--r-- | src/primitives/transaction.h | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/src/primitives/transaction.h b/src/primitives/transaction.h index 1c846d38ec..360615ec56 100644 --- a/src/primitives/transaction.h +++ b/src/primitives/transaction.h @@ -388,11 +388,6 @@ struct CMutableTransaction */ uint256 GetHash() const; - friend bool operator==(const CMutableTransaction& a, const CMutableTransaction& b) - { - return a.GetHash() == b.GetHash(); - } - bool HasWitness() const { for (size_t i = 0; i < vin.size(); i++) { |