diff options
author | Peter Todd <pete@petertodd.org> | 2015-11-13 15:52:07 -0500 |
---|---|---|
committer | Peter Todd <pete@petertodd.org> | 2015-11-13 15:53:46 -0500 |
commit | 10953a7d3241f66ab3b2921e0825d6857f64f6f7 (patch) | |
tree | 33aaafb75be171848b1147396d8b26ab36d3e37e /src | |
parent | 61e1eb2e1c038ef10009921d0e991b4d1f262f51 (diff) |
Better error message for fundrawtransaction w/ empty vout
Previously this case failed deep in Cwallet::CreateTransaction() with
the error message "Transaction amounts must be positive"
Diffstat (limited to 'src')
-rw-r--r-- | src/wallet/rpcwallet.cpp | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/wallet/rpcwallet.cpp b/src/wallet/rpcwallet.cpp index 0bd1303272..7b7c9b3256 100644 --- a/src/wallet/rpcwallet.cpp +++ b/src/wallet/rpcwallet.cpp @@ -2418,6 +2418,9 @@ UniValue fundrawtransaction(const UniValue& params, bool fHelp) if (!DecodeHexTx(origTx, params[0].get_str())) throw JSONRPCError(RPC_DESERIALIZATION_ERROR, "TX decode failed"); + if (origTx.vout.size() == 0) + throw JSONRPCError(RPC_INVALID_PARAMETER, "TX must have at least one output"); + bool includeWatching = false; if (params.size() > 1) includeWatching = params[1].get_bool(); |