diff options
| author | Jeff Garzik <jgarzik@exmulti.com> | 2012-04-22 13:59:24 -0400 |
|---|---|---|
| committer | Jeff Garzik <jgarzik@redhat.com> | 2012-04-23 14:14:36 -0400 |
| commit | 5aa0b2382515eb92fe249a106059f3b6a9328d26 (patch) | |
| tree | bea59d8369abddbe0f517270708404822a98b198 /src | |
| parent | 1d8c7a9557d596d4c7edee801a724db7a908bce5 (diff) | |
CBlock::WriteToDisk() properly checks ftell(3) for error return
Rather than storing ftell(3)'s return value -- a long -- in an
unsigned int, we store and check a properly typed temp. Then, assured a
non-negative value, we store in nBlockPosRet.
Diffstat (limited to 'src')
| -rw-r--r-- | src/main.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/main.h b/src/main.h index 423891c3bc..262e77e806 100644 --- a/src/main.h +++ b/src/main.h @@ -944,9 +944,10 @@ public: fileout << FLATDATA(pchMessageStart) << nSize; // Write block - nBlockPosRet = ftell(fileout); - if (nBlockPosRet == -1) + long fileOutPos = ftell(fileout); + if (fileOutPos < 0) return error("CBlock::WriteToDisk() : ftell failed"); + nBlockPosRet = fileOutPos; fileout << *this; // Flush stdio buffers and commit to disk before returning |