diff options
author | Peter Todd <pete@petertodd.org> | 2014-11-10 02:52:28 -0500 |
---|---|---|
committer | Wladimir J. van der Laan <laanwj@gmail.com> | 2014-12-22 12:42:58 +0100 |
commit | 0cb8763cbbece4b25ea9e9bd756bfefd52ce23d8 (patch) | |
tree | 07d40c8d9e2a79e8933a14017ca26a3d29f8885a /src | |
parent | b03632a6710e9bb1f7d73e0ccd39860c591d84e9 (diff) | |
download | bitcoin-0cb8763cbbece4b25ea9e9bd756bfefd52ce23d8.tar.xz |
Check against MANDATORY flags prior to accepting to mempool
Previously transactions were only tested again the
STANDARD_SCRIPT_VERIFY_FLAGS prior to mempool acceptance, so any bugs in
those flags that allowed actually-invalid transactions to pass would
result in allowing invalid transactions into the mempool. Fortunately
there is a second check in CreateNewBlock() that would prevent those
transactions from being mined, resulting in an invalid block, however
this could still be exploited as a DoS attack.
Rebased-From: 7c041b3b91aa08a8f5863382b865a5174281ad03
Diffstat (limited to 'src')
-rw-r--r-- | src/main.cpp | 15 |
1 files changed, 15 insertions, 0 deletions
diff --git a/src/main.cpp b/src/main.cpp index 6c39e10570..a3c65dbb93 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -1053,6 +1053,21 @@ bool AcceptToMemoryPool(CTxMemPool& pool, CValidationState &state, const CTransa { return error("AcceptToMemoryPool: : ConnectInputs failed %s", hash.ToString()); } + + // Check again against just the consensus-critical mandatory script + // verification flags, in case of bugs in the standard flags that cause + // transactions to pass as valid when they're actually invalid. For + // instance the STRICTENC flag was incorrectly allowing certain + // CHECKSIG NOT scripts to pass, even though they were invalid. + // + // There is a similar check in CreateNewBlock() to prevent creating + // invalid blocks, however allowing such transactions into the mempool + // can be exploited as a DoS attack. + if (!CheckInputs(tx, state, view, true, MANDATORY_SCRIPT_VERIFY_FLAGS, true)) + { + return error("AcceptToMemoryPool: : BUG! PLEASE REPORT THIS! ConnectInputs failed against MANDATORY but not STANDARD flags %s", hash.ToString()); + } + // Store transaction in memory pool.addUnchecked(hash, entry); } |