diff options
| author | fanquake <fanquake@gmail.com> | 2023-08-17 13:34:10 +0100 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2023-08-17 13:58:31 +0100 |
| commit | ecb20563b6a0cdd615628da9caa1e7389998119c (patch) | |
| tree | 56b2755fcf80d2c53c8dc9c0e4104e4e613fcd4f /src/wallet | |
| parent | 6d473bad2260fd23c6013581e44c9970b557f495 (diff) | |
| parent | 5e3e83b005518659a69916c373b808da27e51791 (diff) | |
Merge bitcoin/bitcoin#28123: Bugfix: RPC: Remove quotes from non-string oneline descriptions
5e3e83b005518659a69916c373b808da27e51791 RPC/Mining: Document template_request better for getblocktemplate (Luke Dashjr)
de319c61759952318364fbcb28c47f0959d89d0e RPC/rpcdoccheck: Error if a oneline_description has a quote for a non-string (Luke Dashjr)
7c61e9df90579ed42a30016e52355e437733b128 Bugfix: RPC: Remove quotes from non-string oneline descriptions (Luke Dashjr)
Pull request description:
Various JSON Object parameters had a `oneline_description` with quote characters. Fix those, and extend `rpcdoccheck` to detect them.
Also, slightly improve GBT's oneline description for template_request.
ACKs for top commit:
MarcoFalke:
review ACK 5e3e83b005518659a69916c373b808da27e51791
Tree-SHA512: 363d1669a661d0acfc19fddb57e777d781c7246f330cf62160e77dde10a6adcb0249db748127067da1afe1b7d17c71cf611d9fdc3664d6bf5b3f30105637769a
Diffstat (limited to 'src/wallet')
| -rw-r--r-- | src/wallet/rpc/backup.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/wallet/rpc/backup.cpp b/src/wallet/rpc/backup.cpp index 22c31436f1..d100b69d3c 100644 --- a/src/wallet/rpc/backup.cpp +++ b/src/wallet/rpc/backup.cpp @@ -1297,12 +1297,12 @@ RPCHelpMan importmulti() }, }, }, - RPCArgOptions{.oneline_description="\"requests\""}}, + RPCArgOptions{.oneline_description="requests"}}, {"options", RPCArg::Type::OBJ_NAMED_PARAMS, RPCArg::Optional::OMITTED, "", { {"rescan", RPCArg::Type::BOOL, RPCArg::Default{true}, "Scan the chain and mempool for wallet transactions after all imports."}, }, - RPCArgOptions{.oneline_description="\"options\""}}, + RPCArgOptions{.oneline_description="options"}}, }, RPCResult{ RPCResult::Type::ARR, "", "Response is an array with the same size as the input that has the execution result", @@ -1617,7 +1617,7 @@ RPCHelpMan importdescriptors() }, }, }, - RPCArgOptions{.oneline_description="\"requests\""}}, + RPCArgOptions{.oneline_description="requests"}}, }, RPCResult{ RPCResult::Type::ARR, "", "Response is an array with the same size as the input that has the execution result", |