diff options
| author | Wladimir J. van der Laan <laanwj@protonmail.com> | 2020-08-19 14:22:20 +0200 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@protonmail.com> | 2020-08-19 15:04:34 +0200 |
| commit | e9b30126545d6ddd8772363e4079d1e4908ad117 (patch) | |
| tree | 14f466321b99541c0695ffa6e39ec00d44df1959 /src/wallet | |
| parent | 44ddcd887ddf3f62bcfb9c0b59ba2124335dbe94 (diff) | |
| parent | 71e0f07e9c5f0aef532b85c04807dcbedd04e0af (diff) | |
| download | bitcoin-e9b30126545d6ddd8772363e4079d1e4908ad117.tar.xz | |
Merge #19750: refactor: remove unused c-string variant of atoi64()
71e0f07e9c5f0aef532b85c04807dcbedd04e0af util: remove unused c-string variant of atoi64() (Sebastian Falbesoner)
Pull request description:
This is another micro-PR "removing old cruft with potentially sharp edges" (quote by practicalswift, see #19739). Gets rid of the c-string variant of the function `atoi64()`, which is only used in fuzzers and on one place with `wallet/wallet.h` (where it is originally a `std::string` anyways and uses `.c_str()` -- this method call can simply be removed.)
ACKs for top commit:
practicalswift:
ACK 71e0f07e9c5f0aef532b85c04807dcbedd04e0af -- diff looks correct
laanwj:
ACK 71e0f07e9c5f0aef532b85c04807dcbedd04e0af
Tree-SHA512: 4d1d28e2f5274fdbe0652e7a0f83dd416f4d19c1e1a49979927960a3ad40b0990eeaa4374656bf2c6998a965a14d62c1bc78303b7d583d3307c17828030a8e3b
Diffstat (limited to 'src/wallet')
| -rw-r--r-- | src/wallet/wallet.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/wallet/wallet.h b/src/wallet/wallet.h index 6d9512f59a..2f9d301000 100644 --- a/src/wallet/wallet.h +++ b/src/wallet/wallet.h @@ -227,7 +227,7 @@ static inline void ReadOrderPos(int64_t& nOrderPos, mapValue_t& mapValue) nOrderPos = -1; // TODO: calculate elsewhere return; } - nOrderPos = atoi64(mapValue["n"].c_str()); + nOrderPos = atoi64(mapValue["n"]); } |