diff options
| author | fanquake <fanquake@gmail.com> | 2021-03-17 09:39:05 +0800 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2021-03-17 09:54:27 +0800 |
| commit | 993ecafa5eb7f87574e2befc0e2057d4662a7f56 (patch) | |
| tree | f87d3d146549862d3fb158d1c03f51547cdf3856 /src/wallet | |
| parent | d25e28c20b0987c15c55e106de39cd46d32a802b (diff) | |
| parent | 57ff5a42ab89c2774387b53248bbf5902de086b4 (diff) | |
| download | bitcoin-993ecafa5eb7f87574e2befc0e2057d4662a7f56.tar.xz | |
Merge #21417: Misc external signer improvement and HWI 2 support
57ff5a42ab89c2774387b53248bbf5902de086b4 doc: specify minimum HWI version (Sjors Provoost)
03308b2bfaef5cdf2337a1e8f63edf043d98a7c0 rpc: don't require wallet for enumeratesigners (Sjors Provoost)
Pull request description:
HWI just released 2.0. See https://github.com/bitcoin-core/HWI/releases/tag/2.0.0
As of #16546 we already rely on features that are in 2.0 and not in the previous 1.* releases:
* `--chain` param
This shouldn't be a problem, because HWI 2.0 has been released before we release v22.
Misc improvements:
* document that HWI 2.0 is required
* drop wallet requirement for `enumeratesigners`
ACKs for top commit:
achow101:
Code Review ACK 57ff5a42ab89c2774387b53248bbf5902de086b4
Tree-SHA512: 3fb6ba20894e52a116f89525a5f5a1f61d363ccd904e1cffd0e6d095640fc6d2edf0388cd6ae20f83bbc31e5f458255ec090b6e823798d426eba3e45b4336bf9
Diffstat (limited to 'src/wallet')
| -rw-r--r-- | src/wallet/rpcsigner.cpp | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/wallet/rpcsigner.cpp b/src/wallet/rpcsigner.cpp index 607b778c68..696c74d665 100644 --- a/src/wallet/rpcsigner.cpp +++ b/src/wallet/rpcsigner.cpp @@ -32,9 +32,6 @@ static RPCHelpMan enumeratesigners() }, RPCExamples{""}, [](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue { - std::shared_ptr<CWallet> const wallet = GetWalletForJSONRPCRequest(request); - if (!wallet) return NullUniValue; - const std::string command = gArgs.GetArg("-signer", ""); if (command == "") throw JSONRPCError(RPC_WALLET_ERROR, "Error: restart bitcoind with -signer=<cmd>"); std::string chain = gArgs.GetChainName(); |