diff options
author | glozow <gloriajzhao@gmail.com> | 2022-08-11 15:23:15 +0100 |
---|---|---|
committer | glozow <gloriajzhao@gmail.com> | 2022-08-11 15:23:21 +0100 |
commit | acda7e8686a1f7a967d6331a2f6a3a01389c3048 (patch) | |
tree | 907660d452fb199607f8ee42a90bcef0152eb5e0 /src/wallet | |
parent | dd62721ba9c154685169588e356315d0787fdf7d (diff) | |
download | bitcoin-acda7e8686a1f7a967d6331a2f6a3a01389c3048.tar.xz |
[coin selection] consolidate m_change_target and m_min_change_target
These values are both intended for the same thing. Their divergence
seems to be the result of an incomplete rename.
Diffstat (limited to 'src/wallet')
-rw-r--r-- | src/wallet/coinselection.h | 2 | ||||
-rw-r--r-- | src/wallet/spend.cpp | 2 |
2 files changed, 1 insertions, 3 deletions
diff --git a/src/wallet/coinselection.h b/src/wallet/coinselection.h index 9135e48104..e257d3f7c7 100644 --- a/src/wallet/coinselection.h +++ b/src/wallet/coinselection.h @@ -125,8 +125,6 @@ struct CoinSelectionParams { CAmount m_min_change_target{0}; /** Cost of creating the change output. */ CAmount m_change_fee{0}; - /** The pre-determined minimum value to target when funding a change output. */ - CAmount m_change_target{0}; /** Cost of creating the change output + cost of spending the change output in the future. */ CAmount m_cost_of_change{0}; /** The targeted feerate of the transaction being built. */ diff --git a/src/wallet/spend.cpp b/src/wallet/spend.cpp index e266cf6c81..61d86844df 100644 --- a/src/wallet/spend.cpp +++ b/src/wallet/spend.cpp @@ -794,7 +794,7 @@ static util::Result<CreatedTransactionResult> CreateTransactionInternal( coin_selection_params.m_subtract_fee_outputs = true; } } - coin_selection_params.m_change_target = GenerateChangeTarget(std::floor(recipients_sum / vecSend.size()), rng_fast); + coin_selection_params.m_min_change_target = GenerateChangeTarget(std::floor(recipients_sum / vecSend.size()), rng_fast); // Create change script that will be used if we need change CScript scriptChange; |