diff options
author | MarcoFalke <falke.marco@gmail.com> | 2020-07-04 14:12:30 -0400 |
---|---|---|
committer | MarcoFalke <falke.marco@gmail.com> | 2020-07-04 14:13:48 -0400 |
commit | 8783bcc099e9c8e31010ff59260cf4dbac430355 (patch) | |
tree | f7aa97fb42656a12d69d82d8870afece345f68ca /src/wallet | |
parent | 5ec19df687c2a429dd8872d640ce88fdc06ded9b (diff) | |
parent | 961e667600441c35845fcb36b120500c813cd3ed (diff) |
Merge #19444: test: Remove cached directories and associated script blocks from appveyor config
961e667600441c35845fcb36b120500c813cd3ed Remove cached directories and associated script blocks from appveyor CI configuration. (Aaron Clauson)
Pull request description:
Appveyor CI jobs have been failing in the last 24 hours due to a seemingly corrupted cache, see #19440.
It's possible that the appveyor cache issue is related to the[ recent update](https://www.appveyor.com/updates/2020/07/03/) of the Visual Studio 2019 image
PR #19431 changes the "save cache or error" to false in an attempt to avoid a failing CI job from potentially corrupting the cache. In theory the only way a PR could affect the cache is if the `vcpkg` install list changed. That happens very rarely and did not happen in the last 24 hours and so was not the cause of the current cache problems.
I have done some testing with appveyor build jobs on my own fork and found that installing the `vcpkg` dependencies from scratch and doing a full build can now be done in just under 60 minutes. This is the first time in over 5 months I have been able to build Bitcoin Core on appveyor. Either the new Visual Studio 2019 image has dramatically reduced the build time or appveyor images have had their CPU increased.
This PR removes all use of dependency caching from the appveyor CI config. The trade-off is the 15 minutes saved on each build from having the dependencies cached versus the hours maintainers need to spend investigating when the CI jobs start failing.
ACKs for top commit:
MarcoFalke:
ACK 961e667600441c35845fcb36b120500c813cd3ed
Tree-SHA512: 788c7efbfe6e044739ec41b08df30e24e26bfe0f31d1f5695e7243222a2eb649a2b5fd0254a9238fd416661dc05f737b0545d39feea7aa0da2236fffd7683a1b
Diffstat (limited to 'src/wallet')
0 files changed, 0 insertions, 0 deletions