diff options
| author | Ava Chow <github@achow101.com> | 2024-06-14 14:34:48 -0400 |
|---|---|---|
| committer | Ava Chow <github@achow101.com> | 2024-06-14 14:34:48 -0400 |
| commit | 538497ba27f58549876830189346e5b76bd55517 (patch) | |
| tree | 713954b26ce1b5af6be59a4e69e2ccffdd8ad5db /src/wallet | |
| parent | 0b94fb87206616e475566c3667cbaad0e9faa5b0 (diff) | |
| parent | fae3a1f0065064d80ab4c0375a9eaeb666c5dd55 (diff) | |
Merge bitcoin/bitcoin#30255: log: use error level for critical log messages
fae3a1f0065064d80ab4c0375a9eaeb666c5dd55 log: use error level for critical log messages (MarcoFalke)
Pull request description:
This picks up the first commit from https://github.com/bitcoin/bitcoin/pull/29231, but extends it to also cover cases that were missed in it.
As per https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#logging, LogError should be used for severe problems that require the node to shut down.
ACKs for top commit:
stickies-v:
re-ACK fae3a1f0065064d80ab4c0375a9eaeb666c5dd55, I'm ~0 on the latest force push as `user_error` was already logged at the right level through `GetNotifications().fatalError(user_error);` so I'd be in favour of deduplicating/cleaning up this logging logic but can be done in follow-up.
kevkevinpal:
ACK [fae3a1f](https://github.com/bitcoin/bitcoin/pull/30255/commits/fae3a1f0065064d80ab4c0375a9eaeb666c5dd55)
achow101:
ACK fae3a1f0065064d80ab4c0375a9eaeb666c5dd55
Tree-SHA512: 3f99fd25d5a204d570a42d8fb2b450439aad7685692f9594cc813d97253c4df172a6ff3cf818959bfcf25dfcf8ee9a9c9ccc6028fcfcecdb47591e18c77ef246
Diffstat (limited to 'src/wallet')
0 files changed, 0 insertions, 0 deletions