diff options
| author | Matt Corallo <git@bluematt.me> | 2017-07-10 14:29:06 -0400 |
|---|---|---|
| committer | Matt Corallo <git@bluematt.me> | 2017-07-18 11:20:47 -0400 |
| commit | cf82a9e704f56d245cf512d76ba9d0e6b178f3b0 (patch) | |
| tree | fa413cbf28fae3f278a28a6ef72582930b9d50c6 /src/wallet/wallet.h | |
| parent | 7b6e8bc4424006119dc537699c8b3b3121e0b3c3 (diff) | |
| download | bitcoin-cf82a9e704f56d245cf512d76ba9d0e6b178f3b0.tar.xz | |
Do not allow users to get keys from keypool without reserving them
fundrawtransaction allows users to add a change output and then
not have it removed from keypool. While it would be nice to have
users follow the normal CreateTransaction/CommitTransaction process
we use internally, there isnt much benefit in exposing this option,
especially with HD wallets, while there is ample room for users to
misunderstand or misuse this option.
This could be particularly nasty in some use-cases (especially
pre-HD-split) - eg a user might fundrawtransaction, then call
getnewaddress, hand out the address for someone to pay them, then
sendrawtransaction. This may result in the user thinking they have
received payment, even though it was really just their own change!
This could obviously result in needless key-reuse.
Diffstat (limited to 'src/wallet/wallet.h')
| -rw-r--r-- | src/wallet/wallet.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/wallet/wallet.h b/src/wallet/wallet.h index 574fd8710d..bf09b040f6 100644 --- a/src/wallet/wallet.h +++ b/src/wallet/wallet.h @@ -949,7 +949,7 @@ public: * Insert additional inputs into the transaction by * calling CreateTransaction(); */ - bool FundTransaction(CMutableTransaction& tx, CAmount& nFeeRet, int& nChangePosInOut, std::string& strFailReason, bool lockUnspents, const std::set<int>& setSubtractFeeFromOutputs, CCoinControl, bool keepReserveKey = true); + bool FundTransaction(CMutableTransaction& tx, CAmount& nFeeRet, int& nChangePosInOut, std::string& strFailReason, bool lockUnspents, const std::set<int>& setSubtractFeeFromOutputs, CCoinControl); bool SignTransaction(CMutableTransaction& tx); /** |