diff options
| author | Matt Corallo <git@bluematt.me> | 2017-01-17 16:44:25 -0500 |
|---|---|---|
| committer | Matt Corallo <git@bluematt.me> | 2017-04-13 10:36:21 -0400 |
| commit | 9fececb2cbabc52cc375b84bf840fac018cc8121 (patch) | |
| tree | 63e3bda7949b4168b47a219f5fae6bd2d636c32d /src/wallet/wallet.h | |
| parent | d89f8adf256727915346bd564e9c92bee094be36 (diff) | |
| download | bitcoin-9fececb2cbabc52cc375b84bf840fac018cc8121.tar.xz | |
Remove CValidationInterface::UpdatedTransaction
This removes another callback from block connection logic, making it
easier to reason about the wallet-RPCs-returns-stale-info issue.
UpdatedTransaction was previously used by the GUI to display
coinbase transactions only after they have a block built on top of
them. This worked fine for in most cases, but only worked due to a
corner case if the user received a coinbase payout in a block
immediately prior to restart. In that case, the normal process of
caching the most recent coinbase transaction's hash would not work,
and instead it would only work because of the on-load -checkblocks
calling DisconnectBlock and ConnectBlock on the current tip.
In order to make this more robust, a full mapWallet loop after the
first block which is connected after restart was added.
Diffstat (limited to 'src/wallet/wallet.h')
| -rw-r--r-- | src/wallet/wallet.h | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/wallet/wallet.h b/src/wallet/wallet.h index cf90d261a5..381b570872 100644 --- a/src/wallet/wallet.h +++ b/src/wallet/wallet.h @@ -685,6 +685,10 @@ private: */ bool AddWatchOnly(const CScript& dest) override; + // Used to NotifyTransactionChanged of the previous block's coinbase when + // the next block comes in + uint256 hashPrevBestCoinbase; + public: /* * Main wallet lock. @@ -950,8 +954,6 @@ public: bool DelAddressBook(const CTxDestination& address); - void UpdatedTransaction(const uint256 &hashTx) override; - void Inventory(const uint256 &hash) override { { |