diff options
| author | Luke Dashjr <luke-jr+git@utopios.org> | 2020-02-22 05:02:18 +0000 |
|---|---|---|
| committer | Luke Dashjr <luke-jr+git@utopios.org> | 2020-04-02 16:37:42 +0000 |
| commit | b5795a788639305bab86a8b3f6b75d6ce81be083 (patch) | |
| tree | 90081729d4ba7aafcf829c3be555e36bc065b03e /src/wallet/wallet.cpp | |
| parent | 6d2905f57aaeb3ec3b63d31043f7673ca10003f2 (diff) | |
| download | bitcoin-b5795a788639305bab86a8b3f6b75d6ce81be083.tar.xz | |
Wallet: Add warning comments and assert to CWallet::DelAddressBook
Diffstat (limited to 'src/wallet/wallet.cpp')
| -rw-r--r-- | src/wallet/wallet.cpp | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp index b4cbcfd005..9538f4f2b7 100644 --- a/src/wallet/wallet.cpp +++ b/src/wallet/wallet.cpp @@ -3213,6 +3213,11 @@ bool CWallet::SetAddressBook(const CTxDestination& address, const std::string& s bool CWallet::DelAddressBook(const CTxDestination& address) { + // If we want to delete receiving addresses, we need to take care that DestData "used" (and possibly newer DestData) gets preserved (and the "deleted" address transformed into a change entry instead of actually being deleted) + // NOTE: This isn't a problem for sending addresses because they never have any DestData yet! + // When adding new DestData, it should be considered here whether to retain or delete it (or move it?). + assert(!IsMine(address)); + { LOCK(cs_wallet); |