diff options
| author | Russell Yanofsky <russ@yanofsky.org> | 2020-03-10 15:46:20 -0400 |
|---|---|---|
| committer | João Barbosa <joao.paulo.barbosa@gmail.com> | 2020-03-27 15:17:35 +0000 |
| commit | ab31b9d6fe7b39713682e3f52d11238dbe042c16 (patch) | |
| tree | f719291130d3322eaac867b793309f476d8872c1 /src/wallet/test/wallet_test_fixture.h | |
| parent | 3e50fdbe4e5bb98194e88023468bd77dee78b26e (diff) | |
| download | bitcoin-ab31b9d6fe7b39713682e3f52d11238dbe042c16.tar.xz | |
Fix wallet unload race condition
Currently it's possible for ReleaseWallet to delete the CWallet pointer while
it is processing BlockConnected, etc chain notifications.
To fix this, unregister from notifications earlier in UnloadWallet instead of
ReleaseWallet, and use a new RegisterSharedValidationInterface function to
prevent the CValidationInterface shared_ptr from being deleted until the last
notification is actually finished.
Diffstat (limited to 'src/wallet/test/wallet_test_fixture.h')
| -rw-r--r-- | src/wallet/test/wallet_test_fixture.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/wallet/test/wallet_test_fixture.h b/src/wallet/test/wallet_test_fixture.h index 4e4129fb2c..81d8a60b8a 100644 --- a/src/wallet/test/wallet_test_fixture.h +++ b/src/wallet/test/wallet_test_fixture.h @@ -23,6 +23,7 @@ struct WalletTestingSetup: public TestingSetup { std::unique_ptr<interfaces::Chain> m_chain = interfaces::MakeChain(m_node); std::unique_ptr<interfaces::ChainClient> m_chain_client = interfaces::MakeWalletClient(*m_chain, {}); CWallet m_wallet; + std::unique_ptr<interfaces::Handler> m_chain_notifications_handler; }; #endif // BITCOIN_WALLET_TEST_WALLET_TEST_FIXTURE_H |