diff options
| author | Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> | 2022-03-23 17:15:52 +0100 |
|---|---|---|
| committer | Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> | 2022-03-23 17:20:20 +0100 |
| commit | f9ed0aec1bd49f2d01e15519788497723c1a4eaa (patch) | |
| tree | 4a741b27319b39495203fbe6eccaad6bac7902b2 /src/wallet/coinselection.cpp | |
| parent | bc562b9ef81d4e37c20c4fdbd73be44d6f12efa0 (diff) | |
| parent | 7f90dc26c8938f348938929b6d8bf1ea6f149209 (diff) | |
| download | bitcoin-f9ed0aec1bd49f2d01e15519788497723c1a4eaa.tar.xz | |
Merge bitcoin-core/gui#568: options: flip listenonion to false if not listening
7f90dc26c8938f348938929b6d8bf1ea6f149209 options: flip listenonion to false if not listening (Vasil Dimov)
Pull request description:
If the user has unchecked "Allow incoming connections" in
`Settings->Options...->Network` then `fListen=false` is saved in
`~/.config/Bitcoin/Bitcoin-Qt.conf`. This flips `-listen` to `false`
during startup, but leaves `-listenonion` to `true`.
This flipping of `-listen` is done in `OptionsModel::Init()` after
`InitParameterInteraction()` has been executed which would have flipped
`-listenonion`, should it have seen `-listen` being `false`
(this is a difference between `bitcoind` and `bitcoin-qt`).
Fixes: https://github.com/bitcoin-core/gui/issues/567
ACKs for top commit:
mzumsande:
Tested ACK 7f90dc26c8938f348938929b6d8bf1ea6f149209
hebasto:
ACK 7f90dc26c8938f348938929b6d8bf1ea6f149209
jonatack:
utACK 7f90dc26c8938f348938929b6d8bf1ea6f149209
ryanofsky:
Code review ACK 7f90dc26c8938f348938929b6d8bf1ea6f149209.
Tree-SHA512: ff5095096858eae696293dc58d1cd5bd1bb60ef7c5d07d87308a0cf71c67da88cc00b301b550704625f136c4ba3a29905a934a766535a6422fe85d9662299d32
Diffstat (limited to 'src/wallet/coinselection.cpp')
0 files changed, 0 insertions, 0 deletions