diff options
| author | Wladimir J. van der Laan <laanwj@protonmail.com> | 2021-02-18 13:52:31 +0100 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@protonmail.com> | 2021-02-18 14:01:57 +0100 |
| commit | 860f9168034f0f43e419e5a01024d87236677be6 (patch) | |
| tree | 4a921af3f9989e35270f089ed6b20ff62c26d3b7 /src/versionbits.cpp | |
| parent | db656db2ed5aecc6e623fd3ef1e1bb34207b9e57 (diff) | |
| parent | 9f21ed4037758f407b536c0dd129f8da83173c79 (diff) | |
Merge #20524: test: Move MIN_VERSION_SUPPORTED to p2p.py
9f21ed4037758f407b536c0dd129f8da83173c79 [test] Check user agent string from test framework connections (John Newbery)
9ce4c3c4c1682032500c97af2d6383897b87c413 [test] Add P2P_SERVICES to p2p.py (John Newbery)
010542614dbebba5f5ad6a58c0554930e9e214fc [test] Move MY_RELAY to p2p.py (John Newbery)
9b4054cb7af22123c7fcc4989e143606a630b2af [test] Move MY_SUBVERSION to p2p.py (John Newbery)
7e158a69104831611462cb555da931331b237c78 [test] Move MY_VERSION to p2p.py (John Newbery)
652311165c4ef298dab71d7162f9054abf439f77 [test] Move MIN_VERSION_SUPPORTED to p2p.py (John Newbery)
Pull request description:
The messages.py module should contain code and helpers for
[de]serializing p2p messages. Specific usage of those messages should
be in p2p.py. This PR moves test framework specific constants to p2p.py.
It also changes the SUBVERSION constant to be a string instead of a bytes object. That means that it needs to be explicitly converted to a bytes object to serialize into a version message. Failing to do so would cause an easy-to-spot bug. This should avoid silent failures like the one solved in #20522.
ACKs for top commit:
laanwj:
Code review ACK 9f21ed4037758f407b536c0dd129f8da83173c79
Tree-SHA512: 41d46575ac0ec36ad074d6c6a5b9cef50b05eeb8ddd8ed0a8f0d0c4617cc7b8baa6580af5b83a668230ce1ac27bf0e56914d0361a48b1b05fd75e2e60350eeaf
Diffstat (limited to 'src/versionbits.cpp')
0 files changed, 0 insertions, 0 deletions