validation: Have ChainstateManager own m_chainparams

We want m_chainparams to be alive for the duration of
ChainstateManager's lifetime since ChainstateManager's behaviour depends
on m_chainparams.

We could allow for a std::shared_ptr to be passed in as m_chainparams,
but that complicates things further. Given that CChainParams is not an
entity class or struct, we can just copy it and have ChainstateManager
own it.

1 files changed, 1 insertions, 1 deletions

diff --git a/src/validation.h b/src/validation.h
index 6f4404e7ec..31dd089005 100644
--- a/src/validation.h
+++ b/src/validation.h
@@ -836,7 +836,7 @@ private:
 
     CBlockIndex* m_best_invalid GUARDED_BY(::cs_main){nullptr};
 
-    const CChainParams& m_chainparams;
+    const CChainParams m_chainparams;
 
     const std::function<int64_t()> m_adjusted_time_callback;