diff options
| author | Wladimir J. van der Laan <laanwj@protonmail.com> | 2019-10-25 12:02:53 +0200 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@protonmail.com> | 2019-10-25 12:03:01 +0200 |
| commit | 366753e46e1fc17724c6464bf0213c5a602f90d0 (patch) | |
| tree | 9645160b882190b15cbb1a686a8ede32d834e6ea /src/validation.cpp | |
| parent | fce7c7542234ba3eea05a334b01810d28441eaf2 (diff) | |
| parent | 50037e97d11356218c4b36767232e47b74742b0b (diff) | |
Merge #17231: depends: fix boost mac cross build with clang 9+
50037e97d11356218c4b36767232e47b74742b0b depends: fix boost mac cross build with clang 9+ (Cory Fields)
Pull request description:
The ancient "darwin-4.9.1" profile has long been used to match against clang, which prior to version 9, reported 4.9.1 as its version when invoking "clang++ -dumpversion". Presumably this was a historical compatibility quirk related to Apple's switch from gcc to clang.
This was "fixed" in clang 9.0, so that -dumpversion reports the real version. Unfortunately that had the side-effect of breaking the (brittle) boost compiler detection.
Move to the seemingly more-correct "clang-darwin" profile, which passes the checks and builds correctly.
Also switch to using ar rather than libtool for archiving, as it's what the clang-darwin profile expects to be using.
Note that because this is using a different profile, some of the final command-line arguments end up changing. Those changes look sane at a glance.
ACKs for top commit:
fanquake:
ACK 50037e97d11356218c4b36767232e47b74742b0b - tested on on macOS, will wait for the gitian build.
Tree-SHA512: eac1f353513a445add6fbece7fc78dd3dbdde5e2219bfb7739b82f40bb14de449667a94d2e303d43c67d9b38e7ceb0ba5f0d8fe20b40be2017b1ca0875467c2c
Diffstat (limited to 'src/validation.cpp')
0 files changed, 0 insertions, 0 deletions