diff options
| author | fanquake <fanquake@gmail.com> | 2023-10-20 14:22:15 +0100 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2023-10-20 14:39:34 +0100 |
| commit | 3c856e2fe86ae7d245de09921bd1df15f02c93a3 (patch) | |
| tree | a1a8e4513f1fc418d46f830984b962ac1ca06be8 /src/validation.cpp | |
| parent | fc1073bb450d67d5229123bd9bd9a0c1f4dc7cd3 (diff) | |
| parent | ec84f999f1408b7f1ff4498f78c33b34c30e934c (diff) | |
Merge bitcoin/bitcoin#28569: log: Don't log cache rebalancing in absense of a snapshot chainstate
ec84f999f1408b7f1ff4498f78c33b34c30e934c log: Don't log cache rebalancing in absense of a snapshot chainstate (Fabian Jahr)
Pull request description:
I have noticed that this log now is always printed, even if there is no snapshot chainstate present or even was present. I think this is confusing to users that have never even thought about using assumeutxo since in that case the rebalancing is just ensuring the normal environment with one chainstate. So I suggest we don't log in absence of a snapshot chainstate. We could also think about rewording the message instead but I think this is simpler.
ACKs for top commit:
stickies-v:
utACK ec84f999f1408b7f1ff4498f78c33b34c30e934c
glozow:
concept ACK ec84f999f1408b7f1ff4498f78c33b34c30e934c, don't have opinions other than removing confusing log
theStack:
utACK ec84f999f1408b7f1ff4498f78c33b34c30e934c
Tree-SHA512: 30bbfc648e7c788106f78d52e47a3aa1e1874f65d13743643dc50bcf7f450d8330711ff9fdeac361722542da6051533153829c6d49033227ed315e111afc899f
Diffstat (limited to 'src/validation.cpp')
| -rw-r--r-- | src/validation.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/validation.cpp b/src/validation.cpp index 290db8c9b2..2600f0f9fe 100644 --- a/src/validation.cpp +++ b/src/validation.cpp @@ -5711,8 +5711,8 @@ void ChainstateManager::MaybeRebalanceCaches() assert(ibd_usable || snapshot_usable); if (ibd_usable && !snapshot_usable) { - LogPrintf("[snapshot] allocating all cache to the IBD chainstate\n"); - // Allocate everything to the IBD chainstate. + // Allocate everything to the IBD chainstate. This will always happen + // when we are not using a snapshot. m_ibd_chainstate->ResizeCoinsCaches(m_total_coinstip_cache, m_total_coinsdb_cache); } else if (snapshot_usable && !ibd_usable) { |